1.2.11 branch: coverity errors

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/47820

• Created at 2014-06-20 06:28:00 by nhosoi (@nhosoi)
• Closed as Fixed
• Assigned to nhosoi (@nhosoi)
• Associated bugzillas
  • https://bugzilla.redhat.com/show_bug.cgi?id=1111404

---

Cppcheck Warnings
1. Defect type: CPPCHECK_WARNING
1. 389-ds-base-1.2.11.15/ldap/servers/slapd/back-ldbm/ldbm_search.c:1795:error[uninitvar] – Uninitialized variable: op
op is not initialized, but if jump to line 1793 with no op initialized, rc is 0. Thus, there's no chance to do NULL reference.

Deadcode
1. Defect type: UNUSED_VALUE ¶
1. 389-ds-base-1.2.11.15/ldap/servers/slapd/daemon.c:1894:returned_pointer – Pointer "slapdFrontendConfig" returned by "getFrontendConfig()" is never used.
This defect is a bug but benign.

Clang
1. Defect type: CLANG_WARNING
1. 389-ds-base-1.2.11.15/ldap/servers/slapd/valueset.c:1116:20:warning – Array access (via field 'va') results in a null pointer dereference
It's guaranteed that vs->va is not NULL and the array index is less than the array size.

2. Defect type: CLANG_WARNING
1. 389-ds-base-1.2.11.15/ldap/servers/slapd/valueset.c:1090:26:warning – Array access (via field 'va') results in a null pointer dereference
It's guaranteed that vs->va is not NULL.

3. Defect type: CLANG_WARNING
1. 389-ds-base-1.2.11.15/ldap/servers/slapd/daemon.c:1896:6:warning – Value stored to 'maxthreads' during its initialization is never read
Benign.

4. Defect type: CLANG_WARNING
1. 389-ds-base-1.2.11.15/ldap/servers/slapd/daemon.c:1894:25:warning – Value stored to 'slapdFrontendConfig' during its initialization is never read
Benign.

5. Defect type: CLANG_WARNING
1. 389-ds-base-1.2.11.15/ldap/servers/slapd/daemon.c:1091:21:warning – Dereference of null pointer (loaded from variable 'nap')
Benign.

6. Defect type: CLANG_WARNING
1. 389-ds-base-1.2.11.15/ldap/servers/slapd/back-ldbm/ldbm_search.c:455:25:warning – Value stored to 'virtual_list_view' is never read
Porting bug (bz1109952; DS 47780).  Need to fix it.

7. Defect type: CLANG_WARNING
1. 389-ds-base-1.2.11.15/ldap/servers/slapd/back-ldbm/ldbm_add.c:1110:2:warning – Value stored to 'noabort' is never read
Benign.

Compiler Warnings
1. Defect type: COMPILER_WARNING ¶
2. 389-ds-base-1.2.11.15/ldap/servers/slapd/libglobs.c:5099:warning – format '%lld' expects type 'long long int', but argument 6 has type 'long int'
2. Defect type: COMPILER_WARNING ¶
2. 389-ds-base-1.2.11.15/ldap/servers/slapd/libglobs.c:3734:warning – format '%lld' expects type 'long long int', but argument 6 has type 'long int'
3. Defect type: COMPILER_WARNING ¶
2. 389-ds-base-1.2.11.15/ldap/servers/slapd/libglobs.c:3696:warning – format '%lld' expects type 'long long int', but argument 6 has type 'long int'
4. Defect type: COMPILER_WARNING ¶
2. 389-ds-base-1.2.11.15/ldap/servers/slapd/libglobs.c:3666:warning – format '%lld' expects type 'long long int', but argument 6 has type 'long int'
5. Defect type: COMPILER_WARNING
2. 389-ds-base-1.2.11.15/ldap/servers/slapd/libglobs.c:3470:warning – format '%lld' expects type 'long long int', but argument 6 has type 'long int'
6. Defect type: COMPILER_WARNING
2. 389-ds-base-1.2.11.15/ldap/servers/slapd/libglobs.c:3367:warning – format '%lld' expects type 'long long int', but argument 6 has type 'long int'
7. Defect type: COMPILER_WARNING ¶
2. 389-ds-base-1.2.11.15/ldap/servers/slapd/libglobs.c:3325:warning – format '%lld' expects type 'long long int', but argument 6 has type 'long int'
8. Defect type: COMPILER_WARNING ¶
2. 389-ds-base-1.2.11.15/ldap/servers/slapd/libglobs.c:2596:warning – format '%lld' expects type 'long long int', but argument 5 has type 'long int'
9. Defect type: COMPILER_WARNING
2. 389-ds-base-1.2.11.15/ldap/servers/slapd/libglobs.c:1833:warning – format '%lld' expects type 'long long int', but argument 6 has type 'long int'
10. Defect type: COMPILER_WARNING ¶
2. 389-ds-base-1.2.11.15/ldap/servers/slapd/libglobs.c:1789:warning – format '%lld' expects type 'long long int', but argument 6 has type 'long int'
11. Defect type: COMPILER_WARNING ¶
2. 389-ds-base-1.2.11.15/ldap/servers/slapd/libglobs.c:1291:warning – format '%lld' expects type 'long long int', but argument 6 has type 'long int'
1 through 11. Defect type: benign.

12. Defect type: COMPILER_WARNING ¶
2. 389-ds-base-1.2.11.15/ldap/servers/slapd/daemon.c:1896:warning – unused variable 'maxthreads'
    already addressed 3. Defect type: CLANG_WARNING

13. Defect type: COMPILER_WARNING
1. 389-ds-base-1.2.11.15/ldap/servers/slapd/daemon.c:1895:warning – unused variable 'idletimeout'
Benign.

14. Defect type: COMPILER_WARNING ¶
1. 389-ds-base-1.2.11.15/ldap/servers/slapd/daemon.c:1894:warning – unused variable 'slapdFrontendConfig'
    already addressed 1. Defect type: UNUSED_VALUE ¶

15. Defect type: COMPILER_WARNING
2. 389-ds-base-1.2.11.15/ldap/servers/slapd/daemon.c:1788:warning – 'compute_idletimeout' defined but not used
Benign.

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2014-06-20 06:40:35

git patch file (389-ds-base-1.2.11)
0001-Ticket-47820-1.2.11-branch-coverity-errors.patch

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2014-06-20 06:54:30

Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1111404

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2014-06-20 07:13:13

Reviewed by Rich (Thank you!!)

Pushed to 389-ds-base-1.2.11:
6f6142e..ef7473d 389-ds-base-1.2.11 -> 389-ds-base-1.2.11
commit ef7473d

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2017-02-11 22:48:46

Metadata Update from @nhosoi:

• Issue assigned to nhosoi
• Issue set to the milestone: 1.2.11.30