coverity defects in slapd/tools/mmldif.c

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/47876

• Created at 2014-08-22 03:02:20 by nhosoi (@nhosoi)
• Closed as Fixed
• Assigned to nhosoi (@nhosoi)

---

1. Defect type: CLANG_WARNING

   1. 389-ds-base-1.2.11.15/ldap/servers/slapd/tools/mmldif.c:1404:5:warning – Value stored to 'att' is never read
      att is initialized twice.

   2. Defect type: CLANG_WARNING

   3. 389-ds-base-1.2.11.15/ldap/servers/slapd/tools/mmldif.c:1322:5:warning – Value stored to 'rc' is never read
      no need to check rc there.

   4. Defect type: CLANG_WARNING

   5. 389-ds-base-1.2.11.15/ldap/servers/slapd/tools/mmldif.c:1148:25:warning – Access to field 'next' results in a dereference of a null pointer (loaded from variable 'a')
      false positive.
      cmp < 0 means a is not NULL.

   6. Defect type: CLANG_WARNING

   7. 389-ds-base-1.2.11.15/ldap/servers/slapd/tools/mmldif.c:522:9:warning – Value stored to 'count' is never read
      count is not used.

   8. Defect type: CLANG_WARNING

   9. 389-ds-base-1.2.11.15/ldap/servers/slapd/tools/mmldif.c:518:9:warning – Value stored to 'pmask' is never read
      pmask is not used.

   10. Defect type: CLANG_WARNING

   11. 389-ds-base-1.2.11.15/ldap/servers/slapd/tools/mmldif.c:517:9:warning – Value stored to 'pindex' is never read
       pindex is not used.

   12. Defect type: CLANG_WARNING

   13. 389-ds-base-1.2.11.15/ldap/servers/slapd/tools/mmldif.c:447:9:warning – Value stored to 'pmask' is never read
       pmask is not used.

   14. Defect type: CLANG_WARNING

   15. 389-ds-base-1.2.11.15/ldap/servers/slapd/tools/mmldif.c:446:9:warning – Value stored to 'pindex' is never read
       pindex is not used.

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2014-08-22 04:18:40

git patch file (master)
0001-Ticket-47876-coverity-defects-in-slapd-tools-mmldif..patch

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2014-08-26 05:08:25

Reviewed by Thierry (Thank you!!)

Pushed to master:
0a69c4d..29684ac master -> master
commit 29684ac

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2017-02-11 22:56:00

Metadata Update from @nhosoi:

• Issue assigned to nhosoi
• Issue set to the milestone: 1.3.3 backlog