Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing warning for invalid replica backoff configuration #1337

Closed
389-ds-bot opened this issue Sep 12, 2020 · 20 comments
Closed

Missing warning for invalid replica backoff configuration #1337

389-ds-bot opened this issue Sep 12, 2020 · 20 comments
Labels
closed: fixed Migration flag - Issue
Milestone

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/48006


Description of a problem:
In the scenario where attributes nsds5ReplicaBackoffMin >
nsds5ReplicaBackoffMax were set using dse.ldif, an error/warning is logged to
indicate the inconsistency only on the server startup. It should be logged when
configuration is performed using cn=config as well.

Steps to Reproduce:
1. Set up a replica
2. Configure nsds5ReplicaBackoffMin > nsds5ReplicaBackoffMax using cn=config.

Actual results:
The warning is not logged.

Expected results:
The warning is logged.
[23/Jan/2015:15:37:48 +0100] NSMMReplicationPlugin - Backoff minimum (10) can
not be greater than the backoff maximum (3).  Using default values: min (3) max
(300)
@389-ds-bot 389-ds-bot added the closed: fixed Migration flag - Issue label Sep 12, 2020
@389-ds-bot 389-ds-bot added this to the 1.3.7.0 milestone Sep 12, 2020
@389-ds-bot
Copy link
Author

Comment from nhosoi (@nhosoi) at 2017-02-11 22:50:59

Metadata Update from @nhosoi:

  • Issue set to the milestone: 1.3.6.0

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2017-05-08 22:27:27

Metadata Update from @mreynolds389:

  • Custom field component reset (from Replication - General)
  • Issue close_status updated to: None
  • Issue set to the milestone: 1.3.7.0 (was: 1.3.6.0)

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2017-10-12 22:27:17

Metadata Update from @mreynolds389:

  • Issue assigned to mreynolds389

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2017-10-12 22:47:15

0001-Ticket-48006-Missing-warning-for-invalid-replica-bac.patch

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2017-10-12 22:47:16

Metadata Update from @mreynolds389:

  • Custom field component adjusted to None
  • Custom field reviewstatus adjusted to review
  • Custom field version adjusted to None

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2017-10-17 16:58:59

26 +                        PRUint64 max;

Can we make this uint64_t max = 0; ?

Otherwise I'm happy with it :) ack from me,

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2017-10-17 18:43:28

Can we make this uint64_t max = 0; ?
Otherwise I'm happy with it :) ack from me,

Done:

0001-Ticket-48006-Missing-warning-for-invalid-replica-bac.patch

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2017-10-18 22:11:08

478a2ae..e123acb master -> master

4875300..c7d13c2 389-ds-base-1.3.7 -> 389-ds-base-1.3.7

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2017-10-18 22:11:08

Metadata Update from @mreynolds389:

  • Custom field reviewstatus adjusted to ack (was: review)
  • Issue tagged with: RFE

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2017-10-18 22:11:35

Metadata Update from @mreynolds389:

  • Issue untagged with: RFE
  • Issue close_status updated to: fixed
  • Issue status updated to: Closed (was: Open)

@389-ds-bot
Copy link
Author

Comment from aadhikari at 2018-01-12 18:17:37

0001-Issue-48006-Issue-48006-Add-a-new-CI-test-case.patch

@389-ds-bot
Copy link
Author

Comment from aadhikari at 2018-01-12 18:18:14

Metadata Update from @aadhikari:

  • Custom field reviewstatus adjusted to review (was: ack)

@389-ds-bot
Copy link
Author

Comment from aadhikari at 2018-01-12 18:21:23

0001-Issue-48006-Add-a-new-CI-test-case.patch

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2018-01-18 04:00:16

Can you rebase to master and check again? The repl patch has merged,

@389-ds-bot
Copy link
Author

Comment from aadhikari at 2018-01-18 11:45:37

@Firstyear sure, I have uploaded this patch much before our chat on the channel, so was unaware of it.

@389-ds-bot
Copy link
Author

Comment from aadhikari at 2018-01-18 13:59:00

0001-Issue-48006-Add-a-new-CI-test-case.patch

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2018-01-19 00:56:16

This looks good, but can you reset the config too? Should be something like:

replica.remove('attr')

Should trigger the default value to be reapplied at the end.

@389-ds-bot
Copy link
Author

Comment from aadhikari at 2018-01-19 12:47:49

0001-Issue-48006-Add-a-new-CI-test-case.patch
@Firstyear something like this?

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2018-02-01 09:00:41

Metadata Update from @Firstyear:

  • Custom field reviewstatus adjusted to ack (was: review)

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2018-02-01 12:47:00

commit 0f95ada
Author: Akshay Adhikari aadhikar@aadhikar.pnq.csb
Date: Thu Jan 18 18:16:16 2018 +0530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: fixed Migration flag - Issue
Projects
None yet
Development

No branches or pull requests

1 participant