slapd_daemon should call ns_thrpool_wait instead of while(!g_get_shutdown())

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/48035

• Created at 2015-02-21 03:17:04 by rmeggins (@richm)
• Closed as Fixed
• Assigned to mreynolds (@mreynolds389)

---

while(!g_get_shutdown())
{
#ifdef ENABLE_NUNC_STANS
DS_Sleep(1);
#else

This should just be a call to ns_thrpool_wait like this:

	if (ns_thrpool_wait(tp)) {
            /* error */
        }
        /* start other cleanup here */

[389-ds-bot]

Comment from rmeggins (@richm) at 2015-02-24 01:00:45

listener_info *listener_idxs = NULL; /* array of indexes of listener sockets in the ct->fd array */ 

make this static instead of global

Move the static int listeners = 0; /* number of listener sockets */ to be next to static listener_info *listener_idxs = NULL

                ns_job_done(listener_idxs[i].ns_job);

set listener_idxs[i].ns_job = NULL to make sure no one else tries to reference the job.

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2015-02-24 01:23:31

revision
0001-Ticket-48035-nunc-stans-Revise-shutdown-sequence.patch

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2015-02-24 01:24:46

Replying to [comment:3 richm]:

listener_info *listener_idxs = NULL; /* array of indexes of listener sockets in the ct->fd array */ 

make this static instead of global

Move the static int listeners = 0; /* number of listener sockets */ to be next to static listener_info *listener_idxs = NULL

                ns_job_done(listener_idxs[i].ns_job);

set listener_idxs[i].ns_job = NULL to make sure no one else tries to reference the job.

New patch attached...

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2015-02-24 01:54:18

commit aabcb76e68aa5e8af1883d33ad2266a8d0046dc8

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2017-02-11 22:56:46

Metadata Update from @mreynolds389:

• Issue assigned to mreynolds389
• Issue set to the milestone: 1.3.4 backlog