CI test - ds_logs

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/48067

• Created at 2015-02-26 03:31:58 by nhosoi (@nhosoi)
• Closed at 2019-08-23 21:44:45 as fixed
• Assigned to nobody

---

#No Description Provided

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2017-02-11 22:50:12

Metadata Update from @nhosoi:

• Issue set to the milestone: CI test 1.0

[389-ds-bot]

Comment from sramling at 2017-08-21 09:34:04

Adding bugzilla tests

[389-ds-bot]

Comment from sramling at 2017-08-21 09:34:04

Metadata Update from @sramling:

• Custom field reviewstatus adjusted to None
• Issue close_status updated to: None

[389-ds-bot]

Comment from sramling at 2017-08-21 09:34:19

Metadata Update from @sramling:

• Custom field reviewstatus adjusted to review (was: None)

[389-ds-bot]

Comment from spichugi (@droideck) at 2017-08-21 10:23:15

Thanks for the patch, Sankar.

Could you please use regression_test.py?

We use DEFAULT_SUFFIX in topology, not SUFFIX, though they are the same for now, it can be that some values can be changed later. So let's stick to one.

We have loglevels here -
https://pagure.io/lib389/blob/master/f/lib389/_constants.py#_218
In my opinion, it is better not to hardcode values but use those from lib389. And you can use them directly in mark.parametrize, no need to put into another variable in the beginning of the file.

And one more issue.
I think descriptions are not clear enough. See the comments:

# I think, we need to name tests not "what we do", but "what we test" in regression tests
# So it is not "test_error_log_reset", but something like "test_default_loglevel_stripped"
def test_error_log_reset(topo, log_level):  

# The same here. Something like: "test_dse_config_loglevel_error" instead of "test_dse_error_log"
def test_dse_error_log(topo):
# It is not precise enough. The error occurs only for 64 — Config file processing 
""" Manually setting nsslapd-errorlog-level in dse.ldif throws error  

:id: 0eeefa17-ec1c-4208-8e7b-44d8fbc38f10
:feature: Logging
:setup: Standalone instance
:steps: 1. Stop the server, edit dse.ldif file and change nsslapd-errorlog-level value to 64
        2. Start the server and observe the error logs.
:expectedresults:
        1. Server should be successfully stopped and nsslapd-errorlog-level value should be changed.
        2. Server should be successfully started without any errors being reported in the logs.

[389-ds-bot]

Comment from sramling at 2017-08-21 17:57:06

Patch is updated.

[389-ds-bot]

Comment from spichugi (@droideck) at 2017-08-22 11:15:59

commit 8965a8f
Author: Sankar Ramalingam sramling@redhat.com
Date: Mon Aug 21 21:17:00 2017 +0530

[389-ds-bot]

Comment from spichugi (@droideck) at 2017-08-22 11:16:14

Metadata Update from @droideck:

• Custom field reviewstatus adjusted to ack (was: review)

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2019-08-23 21:44:45

Metadata Update from @mreynolds389:

• Issue close_status updated to: fixed
• Issue status updated to: Closed (was: Open)