--with-initddir in configure should accept "no"

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/48447

• Created at 2016-01-30 14:04:48 by firstyear (@Firstyear)
• Closed as Fixed
• Assigned to firstyear (@Firstyear)

---

Our configure script has the current logic:

If systemd:
- disable
else:
- always use initddir

This isn't good form for porting to other distros. initddir should accept ="no" to prevent the creation of /etc/init.d/rc.d scripts.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-04-06 10:01:27

attachment
0001-Ticket-48447-with-initddir-should-accept-no.patch

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2016-04-19 21:44:41

A question about this line.
472 AM_CONDITIONAL([INITDDIR], [test -z "$with_initdir" -a "$with_initddir" != "no"])

The length of $with_initdir is 0 AND $with_initdir is not "no"? You may want to check the length with '-n'?

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-04-20 04:38:43

I think you are right. I want to check if it's not no AND has some content. I'll fix this up.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-04-20 06:24:20

attachment
0001-Ticket-48447-with-initddir-should-accept-no.2.patch

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-04-20 06:24:41

This update, I checked and double check, the logic is correct.

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2016-04-20 21:46:36

Looks good. Thanks.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-04-26 06:51:19

commit 5c72fee72abfcb5b2d064eb9a640732317d539b1
Total 6 (delta 5), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
b2022ca..2b38bec master -> master

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2017-02-11 23:07:22

Metadata Update from @Firstyear:

• Issue assigned to Firstyear
• Issue set to the milestone: 1.3.5 backlog