Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup lib389 log messages around commands #1810

Closed
389-ds-bot opened this issue Sep 13, 2020 · 7 comments
Closed

Cleanup lib389 log messages around commands #1810

389-ds-bot opened this issue Sep 13, 2020 · 7 comments
Labels
closed: fixed Migration flag - Issue
Milestone

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/48750


Clean up the lib389 log messages around commands so that it's a cleaner user experience.

@389-ds-bot 389-ds-bot added the closed: fixed Migration flag - Issue label Sep 13, 2020
@389-ds-bot 389-ds-bot added this to the lib389 1.0.2 milestone Sep 13, 2020
@389-ds-bot
Copy link
Author

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2016-03-04 23:01:38

Hi William,

I think it is great that you've decided to clean up our logs. But, unfortunately, a lot of lib389 tests fail with your patch.
I think the main reason is that you've deleted "CONF_PRODUCT_NAME" from lib389/_constants.py.

Can you please fix tests too and include changes to your patch? Just be sure that all of them are still pass. :)

Thanks,
Simon

@389-ds-bot
Copy link
Author

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2016-03-08 09:11:10

Hi,

I didn't find anywhere that used it, which is why I removed it. I've put it back now.

Sorry about the confusion.

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2016-03-08 18:12:42

Thanks, all tests PASS. Looks good to me. Ack.

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2016-03-09 05:49:41

commit d33624108669bafa12acd46b4544fee329933fda
To ssh://git.fedorahosted.org/git/389/lib389.git
543f868..d336241 master -> master

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2017-02-11 22:51:29

Metadata Update from @droideck:

  • Issue assigned to Firstyear
  • Issue set to the milestone: lib389 1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: fixed Migration flag - Issue
Projects
None yet
Development

No branches or pull requests

1 participant