PassSync installer overwrites "Notification Packages" value in registry instead of appending it

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/48778

• Created at 2016-03-30 03:32:47 by vashirov (@vashirov)
• Closed as Fixed
• Assigned to nobody
• Associated bugzillas
  • https://bugzilla.redhat.com/show_bug.cgi?id=1322144

---

Description of problem:

https://git.fedorahosted.org/cgit/389/winsync.git/tree/passwordsync/wix/PassSync.wxs#n273
            <RegistryKey Id='NotPkgs' Root='HKLM' Key='SYSTEM\ControlSet001\Control\Lsa' ForceCreateOnInstall='yes' >
              <RegistryValue Name='Notification Packages' Type='multiString' Value='passhook'/>
            </RegistryKey>
Here key "Notification Packages" should be *appended* with the new value 'passhook'. But instead installer *replaces* the old values with the new one.

Before the installation of PassSync:
----
C:\Users\Administrator>reg query HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa /v "Notification Packages"

HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa
    Notification Packages    REG_MULTI_SZ    scecli\0rassfm
----

After the installation of PassSync:
----
C:\Users\Administrator>reg query HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa /v "Notification Packages"

HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa
    Notification Packages    REG_MULTI_SZ    passhook
----

And during the uninstallation it removes the key completely (which also should not happen):
----
C:\Users\Administrator>reg query HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa /v "Notification Packages"

ERROR: The system was unable to find the specified registry key or value.
----

Version-Release number of selected component (if applicable):
RedHat-PassSync-1.1.6-x86_64.msi

How reproducible:
always

Steps to Reproduce:
1. Setup Windows 2008R2 with AD
2. Check the value of "Notification Packages"
reg query HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa /v "Notification Packages"
3. Install passsync
4. Check the value of "Notification Packages"
5. Uninstall passsync
6. Check the value of "Notification Packages"

Actual results:
Old value is replaced with "passhook". 

Expected results:
Value "passhook" should be appended

[389-ds-bot]

Comment from vashirov (@vashirov) at 2016-03-30 03:44:52

attachment
0001-Ticket-48778-PassSync-installer-overwrites-Notificat.patch

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2016-04-26 02:35:16

Forgot to close it... It's already shipped as RedHat-PassSync-1.1.7-x86_64.msi.

[389-ds-bot]

Comment from vashirov (@vashirov) at 2017-02-11 22:57:32

Metadata Update from @vashirov:

• Issue set to the milestone: 389-admin,console 1.1.42