ns-slapd shutdown crashes if pwdstorageschema name is from stack.

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/48902

• Created at 2016-06-28 06:57:48 by firstyear (@Firstyear)
• Closed as Fixed
• Assigned to firstyear (@Firstyear)
• Associated bugzillas
  • https://bugzilla.redhat.com/show_bug.cgi?id=1350632

---

Due to 48872 we now actually free and close plugins correctly.

However, this has exposed a number of issues in other plugins not behaving correctly. In the TET tests the xorplugin assign a name to SLAPI_PLUGIN_PWD_STORAGE_SCHEME_NAME from the stack rather than the heap. When plugin_closeall is called, this causes a segfault as slapi_ch_free_string(&plugin->plg_pwdstorageschemename); is trying to free something that it cannot.

The fix is that we should be strduping the name, and then freeing that in the plugin_free. This way plugins can allocate from heap or stack and we do not cause these faults.

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2016-06-28 07:03:14

Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1350632

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-06-28 08:19:23

attachment
0001-Ticket-48902-Strdup-pwdstoragescheme-name-to-prevent.patch

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2016-06-28 11:25:06

A nice idea!

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-06-29 04:46:01

commit 2309c38
Writing objects: 100% (11/11), 1.46 KiB | 0 bytes/s, done.
Total 11 (delta 8), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
34c9293..2309c38 master -> master

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2017-02-11 23:05:05

Metadata Update from @nhosoi:

• Issue assigned to Firstyear
• Issue set to the milestone: 1.3.5.9