Improve plugin support for lib389 based on new mapped objects

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/48911

• Created at 2016-07-04 08:41:21 by firstyear (@Firstyear)
• Closed at 2017-04-05 05:57:00 as fixed
• Assigned to firstyear (@Firstyear)

---

Add support for managing plugins into the mapped objects. Examples are provided on how we can manage complex plugins, and have the ORM types able to effectively return them during get/list operations to the correct objects.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-07-04 08:43:44

attachment
0001-Ticket-48911-Improve-plugin-support-based-on-new-map.patch

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-07-04 08:45:14

Relies on 48910

[389-ds-bot]

Comment from spichugi (@droideck) at 2016-07-05 03:14:19

Thanks, William!
Very good and useful patch! Looks good to me.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-07-05 06:00:54

commit 2ef056e217dc076496d081e97a0a879dff98c918
Writing objects: 100% (26/26), 6.25 KiB | 0 bytes/s, done.
Total 26 (delta 22), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/lib389.git
bc5428a..2ef056e master -> master

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-07-05 12:55:58

Patch 2 with more fixes
0001-Ticket-48911-Plugin-improvements-for-lib389.patch

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2016-07-05 19:25:47

ack, but we should add common/global plugin tasks to the Plugin class:

- dependency getting/setting/checking
- get/set plugin type
- get/set Shared Config (SLAPI_PLUGIN_SHARED_CONFIG_AREA)
- get/set attribute --> for generic/unknown plugins 
- nsslapd-pluginArg# support --> this is being phased out, but it's still commonly used

These should be pretty simple to add.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-07-06 06:15:34

Replying to [comment:5 mreynolds389]:

ack, but we should add common/global plugin tasks to the Plugin class:

- dependency getting/setting/checking

This would be only on the "advanced" plugin types IE Attribute Uniqueness, rather than the generic. But won't be hard to add.

- get/set plugin type
- get/set Shared Config (SLAPI_PLUGIN_SHARED_CONFIG_AREA)
- get/set attribute --> for generic/unknown plugins 

Already there as a function of deriving DSLdapObject

- nsslapd-pluginArg# support --> this is being phased out, but it's still commonly used

If we are phasing it out, let's leave it out. We are the major consumer of lib389 now, so let's use it the "right way".

If we were to add support, I would want it to be to migrate pluginarg -> named config only.

These should be pretty simple to add.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-07-06 06:16:40

commit c6aedf9bde75e945143d098b49f0d44ee0691860
Writing objects: 100% (6/6), 1.08 KiB | 0 bytes/s, done.
Total 6 (delta 5), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/lib389.git
2ef056e..c6aedf9 master -> master

[389-ds-bot]

Comment from tbordaz (@tbordaz) at 2016-07-07 20:04:50

Hi William,

Instead of 'status' method, why not calling is 'enabled' as it returns the boolean value of nsslapd-pluginenabled==on ?
otherwise it looks good to me.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-07-08 06:55:08

I prefer to keep the function names separate in a linguistic sense. It's easy to mistype

enabled
enable

As well, at a glace, it is hard to see a difference.

So were I to change thing, it would be to something like "enabled_status", or something which is far more unique to the word.

Does that make sense?

[389-ds-bot]

Comment from tbordaz (@tbordaz) at 2016-07-08 13:40:08

Hi William,

I understand the point. The fix looks good to me. Ack

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2017-02-11 23:10:03

Metadata Update from @Firstyear:

• Issue assigned to Firstyear
• Issue set to the milestone: lib389 1.0.3

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2017-04-05 05:57:07

I've implemented a lot of stub classes now, and at this point, each plugin needs individual attention to improve it. I think I can close this and we work on issues as they arise.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2017-04-05 05:57:10

Metadata Update from @Firstyear:

• Custom field reviewstatus adjusted to new
• Issue close_status updated to: fixed
• Issue status updated to: Closed (was: Open)

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2020-02-12 18:59:56

Metadata Update from @mreynolds389:

• Custom field reviewstatus adjusted to None (was: new)
• Issue set to the milestone: None (was: lib389 1.0.3)