New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DS shuts down automatically if dnaThreshold is set to 0 in a MMR setup #1975
Comments
Comment from firstyear (@Firstyear) at 2016-07-11 09:00:25 attachment |
Comment from firstyear (@Firstyear) at 2016-07-11 09:00:44 Adds extra tracing to the module also. |
Comment from tbordaz (@tbordaz) at 2016-07-11 18:28:12 The fix looks good. ack |
Comment from mreynolds (@mreynolds389) at 2016-07-11 20:46:59 One minor issue... The added logging is great, but I think you should use "plugin" logging instead of "trace function call" logging. Trace function call logging has so much overhead, and "technically" this is not how it's supposed to be used anyway as it's meant for logging the entering/exiting of a function. |
Comment from nhosoi (@nhosoi) at 2016-07-11 21:44:24 Replying to [comment:6 mreynolds389]:
+1 How about this SLAPI_LOG_CONFIG level? I'd think this is not set, by default. Better log always with SLAPI_LOG_FATAL to inform it to he administrator?
But in that case, you need to repeat the value is for DNA_THRESHOLD since the previous message is at the SLAPI_LOG_CONFIG level... :) |
Comment from firstyear (@Firstyear) at 2016-07-12 06:52:16 I updated these where it makes sense, I left the --x bailing messages as trace, since they pair with the other trace messages. |
Comment from firstyear (@Firstyear) at 2016-07-12 07:20:49 Update based on comments. |
Comment from nhosoi (@nhosoi) at 2016-07-12 07:27:27 Looks good! You have my ack. |
Comment from firstyear (@Firstyear) at 2016-07-12 07:29:20 commit 05ebb6d |
Comment from nhosoi (@nhosoi) at 2017-02-11 23:10:59 Metadata Update from @nhosoi:
|
Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/48916
Description of problem:
DS shuts down automatically if dnaThreshold is set to 0 in a MMR setup
The text was updated successfully, but these errors were encountered: