log of page result cookie should log empty cookie with a different value than 0

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/48928

• Created at 2016-07-18 21:49:56 by tbordaz (@tbordaz)
• Closed as Fixed
• Assigned to tbordaz (@tbordaz)
• Associated bugzillas
  • https://bugzilla.redhat.com/show_bug.cgi?id=1326077

---

With the ticket https://fedorahosted.org/389/ticket/48752, the cookie value is logged with each page result RESULT.
When the page result is completed (no more entry to return), the returned cookie is 'pr_cookie=0'. Else the cookie value is logged 'pr_cookie='
Unfortunately the index ranges [0..N].

So when the value pr_cookie=0 is logged, it is not possible to know if it is an empty cookie or a valid cookie with the value 0.

The empty cookie should be logged differently

[389-ds-bot]

Comment from spichugi (@droideck) at 2016-07-18 22:06:42

Hi Thierry,
you can use my test case from 48752, it is already at master.
dirsrvtests/tests/suites/paged_results/paged_results_test.py::test_multi_suffix_search

Your current patch contains a typo (I think so):

cookie = 1;

Thanks,
Simon

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2016-07-18 22:28:25

I was adding the same comment a second later you added, Simon! You won. ;)

You are setting 1 in your new proposal 0001-Ticket-48928-log-of-page-result-cookie-should-log-em.patch​, which is conflict with index == 1?
Maybe, a typo? Since you wrote this in the comment? :)

Log the empty cookie with a value '-1'

[389-ds-bot]

Comment from tbordaz (@tbordaz) at 2016-07-18 22:33:13

attachment
0001-Ticket-48928-log-of-page-result-cookie-should-log-em.patch

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2016-07-18 22:40:12

Thanks, Thierry!

[389-ds-bot]

Comment from tbordaz (@tbordaz) at 2016-07-18 22:52:23

'''git push origin master'''
Counting objects: 6, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 928 bytes | 0 bytes/s, done.
Total 6 (delta 4), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
fc97900..73ff835 master -> master

commit 73ff835
Author: Thierry Bordaz tbordaz@redhat.com
Date: Mon Jul 18 18:30:28 2016 +0200

[389-ds-bot]

Comment from nhosoi (@nhosoi) at 2017-02-11 23:09:25

Metadata Update from @nhosoi:

• Issue assigned to tbordaz
• Issue set to the milestone: 1.3.5.12