Allow to compile 389ds with warning Wstrict-prototypes

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/48979

• Created at 2016-09-03 21:39:11 by lslebodn
• Closed as Fixed
• Assigned to nobody

---

freeIPA project compiles C source code with enabled many warnings.
389ds is probably not compiled with this warning and cause issues for freeIPA.

• 0d1ce9d

https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org/message/RT3P4INJVBCLXRBPCCKQDZ7KGHV3AG6D/

If you want to test patches then you need to fix prototype in ssl.h
e.g. sed -e 's/()/(void)/' -i /usr/include/nss3/ssl.h
Otherwise there will be bunch of warnings

  CC       ldap/servers/slapd/libslapd_la-attr.lo
In file included from ldap/servers/slapd/slap.h:109:0,
                 from ldap/servers/slapd/attr.c:25:
/usr/include/nss3/ssl.h:364:1: warning: function declaration isn't a prototype -Wstrict-prototypes]
 SSL_IMPORT unsigned int SSL_SignatureMaxCount();
 ^~~~~~~~~~

[389-ds-bot]

Comment from lslebodn at 2016-09-03 21:57:53

attachment
0001-Ticket-48979-Remove-unused-forward-declaration.patch

[389-ds-bot]

Comment from lslebodn at 2016-09-03 21:58:09

attachment
0002-Ticket-48979-Remove-declaration-of-errno.patch

[389-ds-bot]

Comment from lslebodn at 2016-09-03 21:58:20

attachment
0003-Ticket-48979-Remove-explicit-casting-of-db_env_set_f.patch

[389-ds-bot]

Comment from lslebodn at 2016-09-03 21:58:30

attachment
0004-Ticket-48979-Fix-casting-of-db_env_set_func_seek-cal.patch

[389-ds-bot]

Comment from lslebodn at 2016-09-03 21:58:42

attachment
0005-Ticket-48979-Fix-prototype-of-str2simple.patch

[389-ds-bot]

Comment from lslebodn at 2016-09-03 21:58:51

attachment
0006-Ticket-48979-Fix-prototypes-in-str2filter.c.patch

[389-ds-bot]

Comment from lslebodn at 2016-09-03 21:59:03

attachment
0007-Ticket-48979-Fix-prototype-vlv_getindexnames.patch

[389-ds-bot]

Comment from lslebodn at 2016-09-03 21:59:13

attachment
0008-Ticket-48979-Fix-prototypes-in-plugins-replication-r.patch

[389-ds-bot]

Comment from lslebodn at 2016-09-03 21:59:23

attachment
0009-Ticket-48979-Fix-prototype-setup_internal_backends.patch

[389-ds-bot]

Comment from lslebodn at 2016-09-03 21:59:33

attachment
0010-Ticket-48979-Fix-prototypes-in-repl5_prot_private.h.patch

[389-ds-bot]

Comment from lslebodn at 2016-09-03 21:59:42

attachment
0011-Ticket-48979-Fix-declaration-of-get_substring_filter.patch

[389-ds-bot]

Comment from lslebodn at 2016-09-03 21:59:51

attachment
0012-Ticket-48979-Fix-declarations-in-ldap-servers-slapd-.patch

[389-ds-bot]

Comment from lslebodn at 2016-09-03 21:59:59

attachment
0013-Ticket-48979-Prepare-for-fixing-avl_free-prototype.patch

[389-ds-bot]

Comment from lslebodn at 2016-09-03 22:00:08

attachment
0014-Ticket-48979-Use-strict-prototypes-in-avl.h.patch

[389-ds-bot]

Comment from lslebodn at 2016-09-03 22:00:17

attachment
0015-Ticket-48979-Suppress-warnings-caused-by-undefined-p.patch

[389-ds-bot]

Comment from lslebodn at 2016-09-03 22:00:29

attachment
0017-Ticket-48979-Fix-warnings-Wstrict-prototypes.patch

[389-ds-bot]

Comment from lslebodn at 2016-09-03 22:05:30

attachment
0016-Ticket-48979-Suppress-Wstrict-prototypes.patch

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-09-05 05:41:32

I will begin to review this for you now.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-09-05 06:02:54

Squashed and acked version of Lukas' patch.
0001-Ticket-48979-Allow-to-compile-389ds-with-warning-Wst.patch

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-09-05 06:03:11

Fixes for csn and counters.
0002-Ticket-48979-Strict-Prototypes.patch

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-09-05 06:04:05

ack to your 17 patches. I have squashed these to one patch for commit to the repo.

Do you mind checking my extra patch to confirm it's okay before I push that also? Thanks for all your work on this!

PS: I'm running our test suites to be sure, but I expect no issues. I'll push to the repo when they pass.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-09-05 10:56:09

commit 5b0c9c0
Writing objects: 100% (193/193), 23.58 KiB | 0 bytes/s, done.
Total 193 (delta 169), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
73d74f5..5b0c9c0 master -> master

Pushed Lukas' patch.

[389-ds-bot]

Comment from lslebodn at 2016-09-05 13:30:10

Replying to [comment:2 Firstyear]:

ack to your 17 patches. I have squashed these to one patch for commit to the repo.

I do not like if somebody touches my patches without a permission :-)

I would be fine with squashing patches 5-12 into one.
But other patches solved different issues and therefore should be in different patches. And moreover 17th patch is very u huge itself and

If you prefer small amount of patches in 389-ds then I would survive two patches. But 17th patch should have been pushed without any change. It was already very huge.

[389-ds-bot]

Comment from lslebodn at 2016-09-05 14:00:28

I tried to compile with many various options but I missed "#ifdef DEBUG "

0002-Ticket-48979-Strict-Prototypes.patch​
ACK.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-09-06 04:46:07

Replying to [comment:4 lslebodn]:

Replying to [comment:2 Firstyear]:

ack to your 17 patches. I have squashed these to one patch for commit to the repo.

I do not like if somebody touches my patches without a permission :-)

I would be fine with squashing patches 5-12 into one.
But other patches solved different issues and therefore should be in different patches. And moreover 17th patch is very u huge itself and

If you prefer small amount of patches in 389-ds then I would survive two patches. But 17th patch should have been pushed without any change. It was already very huge.

Sorry, In the past I have done similar (posting many patches) and the team prefers to squash. I completely understand where you are coming from though. For review, the split patches can be nicer depending on the changes. It's already done though, so next time, we'll have to come to some way to make everyone happy.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-09-06 04:46:26

Ack from Lukas.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2016-09-06 06:35:50

commit d46a0f6
Writing objects: 100% (7/7), 819 bytes | 0 bytes/s, done.
Total 7 (delta 5), reused 1 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
5b0c9c0..d46a0f6 master -> master

[389-ds-bot]

Comment from lslebodn at 2017-02-11 22:59:25

Metadata Update from @lslebodn:

• Issue set to the milestone: 0.0 NEEDS_TRIAGE

[389-ds-bot]

Comment from vashirov (@vashirov) at 2020-02-12 17:49:32

Metadata Update from @vashirov:

• Issue set to the milestone: None (was: 0.0 NEEDS_TRIAGE)