New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a short topology fixture alias #2144
Comments
Comment from firstyear (@Firstyear) at 2017-01-11 04:35:50 I don't like the short variable names like "t" as it gives no context to what is happening. I'm guilty sometimes of doing things like this, but I don't think we should encourage it widely. A compromise would be "import topology_m2 as topo" or something like that, which is shorter but at least still indicative or a partial word. Ultimately, is this really a big problem for us? What will this solve for us? How does it help us? |
Comment from spichugi (@droideck) at 2017-01-11 11:06:04 Replying to [comment:1 Firstyear]:
is still very readable. Though I do fully agree to the "'''topo'''" too, it is still better than "'''topology_m1h1c1'''".
|
Comment from firstyear (@Firstyear) at 2017-01-11 12:03:04 Yep, I'm convinced now. Let's go with your plan. The reason I say topo not "t", is search/replace on "t" may not easily work, but at least topo is somewhat unique in a search. |
Comment from spichugi (@droideck) at 2017-01-16 20:38:53 attachment |
Comment from spichugi (@droideck) at 2017-01-16 22:11:53 To ssh://git.fedorahosted.org/git/389/ds.git |
Comment from spichugi (@droideck) at 2017-02-11 22:59:35 Metadata Update from @droideck:
|
Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/49085
There is one more idea/proposal for the create_test.py improving and the way we invoke topology objects.
Instead of writing tests like this:
We can write like this:
For that, I can refactor create_test.py a bit, so it will make all initial actions for you. What do you think?
The text was updated successfully, but these errors were encountered: