Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_test.py --suit in ds/dirsrvtests creates a file, not directory #2227

Closed
389-ds-bot opened this issue Sep 13, 2020 · 4 comments
Closed
Labels
closed: won't fix Migration flag - Issue

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/49168

  • Created at 2017-03-14 10:55:37 by amsharma (@amsharma3)
  • Closed at 2017-03-14 22:05:39 as wontfix
  • Assigned to nobody

Issue Description

create_test.py --suit in ds/dirsrvtests creates a file, not directory

Steps to reproduce

1.python create_test.py --suit setup_ds
Created: setup_ds_test.py

Actual results

Created: setup_ds_test.py

Expected results

It should ideally create a directory for the suit. For ticket it is OK to create a file but for suit, it should create a directory.

@389-ds-bot 389-ds-bot added the closed: won't fix Migration flag - Issue label Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2017-03-14 11:24:28

Hi Amita,
I think it is better as it is because we don't create a lot of suites directories (maybe we will have to create 2-5 dirs, not much of a room for an automation), mostly, they are already created. Though we do create a lot of new modules inside of each test suite directory.

For example, suites/replication has 5 test suite modules and this number will be increased at least two times. The same situation with another test suite directories.

Because of this, I think it is more efficient to keep create_test.py with a file creation, not a directory with a file.

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2017-03-14 11:24:40

Metadata Update from @droideck:

  • Custom field reviewstatus adjusted to new
  • Custom field type adjusted to defect

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2017-03-14 22:05:15

As was discussed on IRC, the file creation stays the same. Closing.

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2017-03-14 22:05:45

Metadata Update from @droideck:

  • Issue close_status updated to: wontfix
  • Issue status updated to: Closed (was: Open)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: won't fix Migration flag - Issue
Projects
None yet
Development

No branches or pull requests

1 participant