389-1.3.6.1-1.el7 covscan errors

[389-ds-bot]

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/49169

• Created at 2017-03-14 16:33:47 by mreynolds (@mreynolds389)
• Closed at 2017-03-15 01:27:23 as fixed
• Assigned to mreynolds (@mreynolds389)
• Associated bugzillas
  • https://bugzilla.redhat.com/show_bug.cgi?id=1431877

---

Ticket was cloned from Red Hat Bugzilla (product Red Hat Enterprise Linux 7): Bug 1431877

Description of problem:

Many covscan errors were detected from 389-ds-base-1.3.6.1-1.el7, these need to
be addressed before releasing a build.

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2017-03-14 16:33:57

Metadata Update from @mreynolds389:

• Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1431877

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2017-03-14 16:33:57

Metadata Update from @mreynolds389:

• Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1431877

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2017-03-14 19:18:33

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2017-03-14 19:18:45

Metadata Update from @mreynolds389:

• Custom field reviewstatus adjusted to review
• Custom field type adjusted to defect

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2017-03-14 23:44:27

Metadata Update from @mreynolds389:

• Issue assigned to mreynolds389

[389-ds-bot]

Comment from nkinder (@nkinder) at 2017-03-15 00:37:46

The patch LGTM.

[389-ds-bot]

Comment from nkinder (@nkinder) at 2017-03-15 00:37:58

Metadata Update from @nkinder:

• Custom field reviewstatus adjusted to ack (was: review)

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2017-03-15 00:42:06

On issue is the free(cur) in map.c of sds. Should be sds_free(cur).

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2017-03-15 01:27:19

Applied Williams suggestion:

770fcf4..c75126b master -> master

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2017-03-15 01:27:29

Metadata Update from @mreynolds389:

• Issue close_status updated to: fixed
• Issue status updated to: Closed (was: Open)

[389-ds-bot]

Comment from vashirov (@vashirov) at 2017-03-15 13:25:13

commit c75126b broke tests, 95 failed, 140 errors.
https://fedorapeople.org/~vashirov/share/report-gitf786639.html

Note that the report is for the latest master, but I bisected it to c75126b

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2017-03-15 14:03:04

Fixed. Problem was with the change to vattr.c - which I undid.

f786639..314e9ec master -> master

[389-ds-bot]

Comment from vashirov (@vashirov) at 2017-03-15 15:32:54

Thanks Mark!
Looks good now: http://fedorapeople.org/~vashirov/share/report-git314e9ec.html