Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sysconf by default #2418

Open
389-ds-bot opened this issue Sep 13, 2020 · 9 comments
Open

Sysconf by default #2418

389-ds-bot opened this issue Sep 13, 2020 · 9 comments
Milestone

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/49359


Issue Description

Through out the code we are inconsistent about our use of sysconf or getdtablesize. We have some defines that are not consistent (such as use_sysconf OR linux) and other places that just look for use sysconf.

We should clean this up,

@389-ds-bot 389-ds-bot added this to the 1.4 backlog milestone Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2017-08-21 07:47:12

0001-Ticket-49359-sysconf-by-default.patch

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2017-08-21 07:47:13

Metadata Update from @Firstyear:

  • Custom field component adjusted to None
  • Custom field origin adjusted to None
  • Custom field reviewstatus adjusted to review
  • Custom field type adjusted to None
  • Custom field version adjusted to None

@389-ds-bot
Copy link
Author

Comment from lkrispen (@elkris) at 2017-08-21 09:29:00

ok. but now getdtablesize() is no more used and we can completely remove it eg. from

 #ifdef SUNOS4

and maybe a lot of stuff in portable.h could be eliminated as well

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2017-08-22 01:13:36

Yep, I completely agree. I saw a lot that I could cleanup in this area tbh. I've wanted to clean up our portability headers for a while, so maybe I will do that too.

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2017-08-23 06:03:18

@elkris Do you want to ack this as is? Or should I clean all of portable.h in this instead? What do you think?

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2017-09-05 01:38:25

@elkris it sounds like @cgrzemba wants to fix our solaris support, so perhaps this should roll into a portability cleanup? Would you be happy for me to fix that up here?

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2017-09-07 17:57:30

Metadata Update from @mreynolds389:

  • Issue set to the milestone: 1.4 backlog

@droideck
Copy link
Member

@Firstyear, it got hanging for a while...
If you still would like to make the change, it'll need PR. :)

Or we can close it if it's not relevant anymore.

@Firstyear
Copy link
Contributor

I still think it's relevant, but I also am not sure I am bothered enough to make a PR ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants