New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3 support for replication suite #2575
Comments
Comment from firstyear (@Firstyear) at 2018-01-04 06:38:50 62 passed, 15 skipped in 2429.54 seconds |
Comment from firstyear (@Firstyear) at 2018-01-04 06:38:58 Metadata Update from @Firstyear:
|
Comment from firstyear (@Firstyear) at 2018-01-04 07:42:31 |
Comment from firstyear (@Firstyear) at 2018-01-04 07:42:43 Metadata Update from @Firstyear:
|
Comment from firstyear (@Firstyear) at 2018-01-04 07:43:11 @droideck I even did docstrings for you :) |
Comment from firstyear (@Firstyear) at 2018-01-04 07:50:19 Forgot to rebase to master, |
Comment from spichugi (@droideck) at 2018-01-04 17:48:42 Ok, for now, I've encountered just these things my testing machine:
I haven't checked everything yet though. These are the things that block me from running the tests. I'll continue checking the code. My environment:
|
Comment from firstyear (@Firstyear) at 2018-01-05 08:34:55 Fixes the missing object Hope that helps mate! |
Comment from spichugi (@droideck) at 2018-01-05 17:53:36 It helped! 18 tests pass now. But others - dont. There is another objectClass violation. Besides that, I continue to review the code. |
Comment from firstyear (@Firstyear) at 2018-01-08 00:37:27 Ahhh yes, I know what would cause this also. Let me update the patch (once more ...) for you :) |
Comment from firstyear (@Firstyear) at 2018-01-08 04:30:53 |
Comment from firstyear (@Firstyear) at 2018-01-08 04:31:05 That should help you out @droideck :) |
Comment from firstyear (@Firstyear) at 2018-01-09 03:23:36 Fixes two more issues @droideck found |
Comment from firstyear (@Firstyear) at 2018-01-16 04:23:07 Rebase for @droideck |
Comment from spichugi (@droideck) at 2018-01-17 06:13:44 Because we really need the code for test automation for BZ verification and the tests mostly pass, I think (and as William proposed) we can one more time try to figure out the issues and push it after this. The first failure:
The second failure is a timing issue: The third failure is about SSL error and the fact that replication doesn't happen:
Error log for master2:
|
Comment from spichugi (@droideck) at 2018-01-17 07:36:33 Ok, I've investigated a bit more. There is my update: dirsrvtests/tests/suites/replication/cleanallruv_test.py::test_abort_restart dirsrvtests/tests/suites/replication/regression_test.py::test_password_repl_error dirsrvtests/tests/suites/replication/tls_client_auth_repl_test.py::test_tls_client_auth Also, it is a new test, could you please change the date on copyright? I think we can push the code after fixing first two failures. The third could be more complicated and it's probably just test related. We need the rest of the replica code you've written. :) Thank you, William! |
Comment from firstyear (@Firstyear) at 2018-01-17 08:54:06 I think I know the cause of the third failure but can't really discuss. Will email, |
Comment from firstyear (@Firstyear) at 2018-01-17 09:39:30 OKay, the first failure is NOT from certify as the current test doesn't have that, but possibly from a lack of waiting on the abort task, looking at the original code, there is no verification, so I think this because I structure the test to do a PROPRE reset which exposes an issue in the lack of abort. Testing now, |
Comment from firstyear (@Firstyear) at 2018-01-17 10:46:52 |
Comment from spichugi (@droideck) at 2018-01-17 14:02:33 Metadata Update from @droideck:
|
Comment from spichugi (@droideck) at 2018-01-17 14:13:36 As per William's request I've checked it once again and have made sure it PASSes. commit e163c44 |
Comment from firstyear (@Firstyear) at 2018-01-18 03:04:48 Thanks @droideck I really appreciate your time to review this, |
Comment from firstyear (@Firstyear) at 2018-01-18 03:04:49 Metadata Update from @Firstyear:
|
Comment from lkrispen (@elkris) at 2018-02-07 12:06:40 It breaks changelog encryption for1.4 because the schema entry for the objectclass nsChangelogConfig is missing the nsslapd-encryptionalgorithm and nsslapd-symmetrickey attributes |
Comment from lkrispen (@elkris) at 2018-02-09 13:41:31
the second attr is nsSymmetricKey. it is defiend later in 50-nsdirectory.ldif file, but allowed in the OC. |
Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/49516
Issue Description
Improve support for the replication test suite to use python 3.
This is important to allow continued testing of an important feature of the server on python 3.
Additionally, this cleans a number of old replication types and adds improvements for the new cli/admin tools.
However, add replication is a large component, this update touches many parts of the lib389 code,
The text was updated successfully, but these errors were encountered: