Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pid file not removed with systemd #262

Closed
389-ds-bot opened this issue Sep 12, 2020 · 7 comments
Closed

pid file not removed with systemd #262

389-ds-bot opened this issue Sep 12, 2020 · 7 comments
Labels
closed: fixed Migration flag - Issue
Milestone

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/262


The initscript and other stop scripts will remove the .pid file at shutdown. However, with systemd, there doesn't appear to be a way to do this. This causes multiple problems:

  1. during setup -u, many of the scripts are only executed when the server is stopped, and they only check for the presence of the .pid file to see if the server is running.

This currently only affects F-16 and later

@389-ds-bot 389-ds-bot added the closed: fixed Migration flag - Issue label Sep 12, 2020
@389-ds-bot 389-ds-bot added this to the 1.2.10.a7 milestone Sep 12, 2020
@389-ds-bot
Copy link
Author

Comment from nhosoi (@nhosoi) at 2012-01-21 06:25:57

Would be a stupid question... You specifically set "/usr/bin/rm" not "/bin/rm". My F14 and F15 do not have /usr/bin/rm, but just /bin/rm.
$ rpm -qf /bin/rm
coreutils-8.10-2.fc15.x86_64

The location of rm is changed on the system which supports systemd?
23 ExecStopPost=/usr/bin/rm -f @localstatedir@/run/@package_name@/slapd-%i.pid

@389-ds-bot
Copy link
Author

Comment from rmeggins (@richm) at 2012-01-21 06:43:30

0001-Ticket-262-pid-file-not-removed-with-systemd.patch
0001-Ticket-262-pid-file-not-removed-with-systemd.patch

@389-ds-bot
Copy link
Author

Comment from rmeggins (@richm) at 2012-01-21 06:44:32

Replying to [comment:2 nhosoi]:

Would be a stupid question... You specifically set "/usr/bin/rm" not "/bin/rm". My F14 and F15 do not have /usr/bin/rm, but just /bin/rm.
$ rpm -qf /bin/rm
coreutils-8.10-2.fc15.x86_64

The location of rm is changed on the system which supports systemd?
23 ExecStopPost=/usr/bin/rm -f @localstatedir@/run/@package_name@/slapd-%i.pid

Good point. I originally had /bin/rm but the systemd guys told me to use /usr/bin instead. Since this doesn't exist on F-16 either, I changed it back to /bin/rm.

@389-ds-bot
Copy link
Author

Comment from rmeggins (@richm) at 2012-01-21 08:20:55

To ssh://git.fedorahosted.org/git/389/ds.git
353b914..c006d67 master -> master
commit changeset:c006d675045ae0da4682bf8c26b2d12a42ebeaf2/389-ds-base
Author: Rich Megginson richm@redhat.com
Date: Fri Jan 20 16:00:20 2012 -0700
Reviewed by: nhosoi (Thanks!)
Branch: master
Fix Description: The PIDDIR directive was problematic - just use the full
path to the pid dir. Add the ExecStopPost directive to remove the .pid
file after shutdown.
Platforms tested: Fedora 16
Flag Day: no
Doc impact: no

@389-ds-bot
Copy link
Author

Comment from rmeggins (@richm) at 2012-01-24 22:07:05

upstream only

@389-ds-bot
Copy link
Author

Comment from nkinder (@nkinder) at 2012-08-28 04:14:38

Added initial screened field value.

@389-ds-bot
Copy link
Author

Comment from rmeggins (@richm) at 2017-02-11 22:50:01

Metadata Update from @richm:

  • Issue assigned to richm
  • Issue set to the milestone: 1.2.10.a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: fixed Migration flag - Issue
Projects
None yet
Development

No branches or pull requests

1 participant