New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR - Issue 49581 - Fix dynamic plugins test suite #2685
Comments
Comment from spichugi (@droideck) at 2018-03-29 18:40:38 rebased onto a817f1bf747684b25d57abc01b19ab8d132b8087 |
Comment from spichugi (@droideck) at 2018-03-30 22:35:45 rebased onto 82eb986c1d3b77c16b3415eecb3a7e0e18d229a1 |
Comment from spichugi (@droideck) at 2018-04-05 12:47:26 rebased onto 0cd4007191ad537c6519596f853f77c0bc6ad1c8 |
Comment from spichugi (@droideck) at 2018-04-06 13:13:57 1 new commit added
|
Comment from spichugi (@droideck) at 2018-04-11 06:50:56 2 new commits added
|
Comment from spichugi (@droideck) at 2018-04-12 12:11:16 rebased onto 9c7a76e27adfff02c40abdd4d49acfa187b97a14 |
Comment from firstyear (@Firstyear) at 2018-04-16 02:04:04 Shouldn't we be doing this through a referint plugin object instead? |
Comment from firstyear (@Firstyear) at 2018-04-16 02:04:48 Is there a need to use extensible object here? |
Comment from spichugi (@droideck) at 2018-04-16 12:24:07 rebased onto 6503cb48f1235b36e417dfd7e9d0bd214ae0a6d7 |
Comment from spichugi (@droideck) at 2018-04-16 12:24:45 Thanks! I fixed it. The changes in the last commit. |
Comment from firstyear (@Firstyear) at 2018-04-16 12:49:34 Great, looks good. I'll let one of the others check too? Maybe @mreynolds389. I haven't run these tests so it would be good for someone else to actually give the branch a go. :) |
Comment from mreynolds (@mreynolds389) at 2018-04-23 17:03:14 Passes for me |
Comment from spichugi (@droideck) at 2018-05-14 10:45:17 rebased onto 7fb2df5ae12835840a8c92ef3923c1f62b596344 |
Comment from spichugi (@droideck) at 2018-05-14 10:45:34 rebased onto 3c2c2101b89ca79902eadec96c9ac4d27d8a1163 |
Comment from vashirov (@vashirov) at 2018-05-17 12:26:07 LGTM |
Comment from spichugi (@droideck) at 2018-05-17 14:56:27 rebased onto dc7f108 |
Comment from spichugi (@droideck) at 2018-05-17 14:57:15 Pull-Request has been merged by droideck |
Patch |
Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/49626
Description: Refactor plugins module and fix tests accordingly.
Add absent Task and Plugin objects. Add docstrings for every
fixed object.
Resolves: #2640
Reviewed by: ?
The text was updated successfully, but these errors were encountered: