Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Issue 49678 - organiSational vs organiZational spelling in lib389 #2740

Closed
389-ds-bot opened this issue Sep 13, 2020 · 10 comments
Closed
Labels
merged Migration flag - PR pr Migration flag - PR

Comments

@389-ds-bot
Copy link

389-ds-bot commented Sep 13, 2020

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/49681

  • Created at 2018-05-13 00:47:14 by vashirov (@vashirov)
  • Merged at 2018-05-23 16:03:03

Bug description:
RFC4519 defines 'organization' object class using Oxford spelling.
It is common for academic, formal, and technical writing for an
international readership. We should be following common spelling
in function names and methods, otherwise it is confusing
and annoying to remember which one is used where.

Fix description:
Use Oxford spelling for 'organization' and 'organizationalUnit'.

Resolves: #2737

Reviewed by: ???

@389-ds-bot 389-ds-bot added merged Migration flag - PR pr Migration flag - PR labels Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2018-05-13 15:54:47

Looks good to me! Ack

@389-ds-bot
Copy link
Author

Comment from vashirov (@vashirov) at 2018-05-21 10:44:21

rebased onto 8c255f2f34f24313ca092daa13c6c4526377e809

@389-ds-bot
Copy link
Author

Comment from vashirov (@vashirov) at 2018-05-21 13:01:39

@kenoh, I've added missing fixes for tests.

@389-ds-bot
Copy link
Author

Comment from vashirov (@vashirov) at 2018-05-21 15:31:31

rebased onto c6ac3cd4762c09a05ddb85dec126fa960237e851

@389-ds-bot
Copy link
Author

Comment from vashirov (@vashirov) at 2018-05-22 17:07:14

rebased onto 4525b23652850552b094bff3f421d8e35cacf61e

@389-ds-bot
Copy link
Author

Comment from mhonek (@kenoh) at 2018-05-23 14:33:40

ACK from me. Just a last one missed probably due to a recent change Simon did, in dirsrvtests/tests/suites/plugins/acceptance_test.py, and feel free to merge. :)

@389-ds-bot
Copy link
Author

Comment from vashirov (@vashirov) at 2018-05-23 16:01:36

rebased onto c1e022d

@389-ds-bot
Copy link
Author

Comment from vashirov (@vashirov) at 2018-05-23 16:02:23

Nice catch! Fixed it as well.
Thanks!

@389-ds-bot
Copy link
Author

Comment from vashirov (@vashirov) at 2018-05-23 16:03:05

Pull-Request has been merged by vashirov

@389-ds-bot
Copy link
Author

Patch
49681.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Migration flag - PR pr Migration flag - PR
Projects
None yet
Development

No branches or pull requests

1 participant