PR - Issue 49820 - lib389 requires wrong python ldap library

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/49821

• Created at 2018-07-02 14:09:31 by vashirov (@vashirov)
• Merged at 2018-07-02 15:44:19

---

Bug Description:
python3-ldap [1] is not the same as python-ldap [2].

[1] https://pypi.org/project/python3-ldap/
[2] https://pypi.org/project/python-ldap/

Fix Description:
Update setup.py and requirements.txt.

Resolves: #2879

Reviewed by: ???

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-07-02 15:06:59

I'm a but confused

[1] https://pypi.org/project/python3-ldap/

This says they renamed it to ldap3.

And what about our spec files where we require python3-ldap, does this mean we have to change those as well? Oo what is different about the specfile requires vs the setup.py/requirements.txt?

[389-ds-bot]

Comment from vashirov (@vashirov) at 2018-07-02 15:20:00

Yeah, it's confusing. Fedora and pypi have different namespaces. So the package named python3-ldap can clash with python3-ldap from pypi, which is actually ldap3 -- an incompatible with python-ldap implementation.

Spec file uses naming conventions from Fedora, setup.py/requirements.txt -- from pypi index. So we don't need to change anything in spec file.

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-07-02 15:40:52

Thanks for the clarification! Ack

[389-ds-bot]

Comment from vashirov (@vashirov) at 2018-07-02 15:43:15

rebased onto b903b03

[389-ds-bot]

Comment from vashirov (@vashirov) at 2018-07-02 15:44:20

Pull-Request has been merged by vashirov

[389-ds-bot]

Patch
49821.patch