PR - Issue 49640 - Cleanup plugin bootstrap logging

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/49822

• Created at 2018-07-02 18:01:37 by spichugi (@droideck)
• Merged at 2018-07-10 17:20:12

---

Bug Description: We add PBKDF2_SHA256 password storage schema two times. During:

1. the dse.ldif parsing;
2. the bootstrap plugin operation.
   It causes the error to appear during the startup.

Fix Description: Make plugin_setup() function report the error to TRACE log level
if the plugin already exists. We will report the error in ERR log level during
the config bootstrap anyway (code path for the 1st option from bug description).
For 2nd option, report the error to TRACE if it is 'already exist' issue
and to ERR if it is any other case.

Make the plugin_setup returns more consistent.

Resolves: #2699

Reviewed by: ?

[389-ds-bot]

Comment from spichugi (@droideck) at 2018-07-03 08:21:56

rebased onto 7ecfefe478266fae0fb6dd792342a2df50a5597f

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-07-10 16:55:55

Is this logging line redundant from what you did in plugin.c?

[389-ds-bot]

Comment from spichugi (@droideck) at 2018-07-10 17:05:33

Is this logging line redundant from what you did in plugin.c

I was thinking that it can potentially help with the debugging.
It points out the function name 'slapd_bootstrap_config' and the configfile where the issue is happening. So we can narrow down the problem if it would happen.

But we use TRACE log level rarely because it's really noisy... So if you think it is too much redundant, I'll remove it.

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-07-10 17:08:33

Good point, ack

[389-ds-bot]

Comment from spichugi (@droideck) at 2018-07-10 17:19:13

rebased onto 2fa0408

[389-ds-bot]

Comment from spichugi (@droideck) at 2018-07-10 17:20:13

Pull-Request has been merged by droideck

[389-ds-bot]

Patch
49822.patch