Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR - Issue 49999 - Integrate React structure into cockpit-389-ds #3059

Closed
389-ds-bot opened this issue Sep 13, 2020 · 13 comments
Closed

PR - Issue 49999 - Integrate React structure into cockpit-389-ds #3059

389-ds-bot opened this issue Sep 13, 2020 · 13 comments
Labels
merged Migration flag - PR pr Migration flag - PR

Comments

@389-ds-bot
Copy link

389-ds-bot commented Sep 13, 2020 •
edited

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50000

  • Created at 2018-10-30 19:04:25 by spichugi (@droideck)
  • Merged at 2018-11-01 17:46:38

Description: Refactor the existing 389-console Cockpit plugin structure
so it uses React, Babel, Eslint.

Reviewed by: ?

Resolves: #3058
@389-ds-bot 389-ds-bot added merged Migration flag - PR pr Migration flag - PR labels Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2018-10-30 19:13:48

Is this "make" supposed to be commented out?

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2018-10-30 19:17:52

Is this "make" supposed to be commented out?

Yes, I'll remove it.
I was experimenting but apperently it is better to use install-data-hook for copying the cockpit_dist files on 'make install'.

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2018-10-30 21:21:08

Everything seems to work, ack!

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2018-10-31 20:09:51

rebased onto a69c3616bf926d79f21805e8bbb6fe84574002c0

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2018-10-31 20:09:55

rebased

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2018-10-31 20:11:04

rebased onto 8d60265f658d46feba5872d8943678dcbfda83e6

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2018-11-01 15:52:21

Its working much better! Ack

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2018-11-01 17:32:07

rebased onto b6808f633725d6a495d66fcad0b998b3c03840f4

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2018-11-01 17:39:33

rebased onto 51af3e5

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2018-11-01 17:46:38

Pull-Request has been merged by droideck

@389-ds-bot
Copy link
Author

Comment from tbordaz (@tbordaz) at 2018-11-06 10:42:29

On a workspace were src/cockpit/389-console/cockpit_dist did not exist before the build. I got 'Not such file or directory'.
After creating the directory, it built successfully.
I do not know where it should be created

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2018-11-06 14:31:07

On a workspace were src/cockpit/389-console/cockpit_dist did not exist before the build. I got 'Not such file or directory'.
After creating the directory, it built successfully.
I do not know where it should be created

I will address it in my next PR. Thank you!

@389-ds-bot
Copy link
Author

Patch
50000.patch

@389-ds-bot 389-ds-bot mentioned this issue Sep 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
merged Migration flag - PR pr Migration flag - PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@389-ds-bot