Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ECDSA private keys for TLS #3069

Closed
389-ds-bot opened this issue Sep 13, 2020 · 10 comments · Fixed by #5365
Closed

Support ECDSA private keys for TLS #3069

389-ds-bot opened this issue Sep 13, 2020 · 10 comments · Fixed by #5365
Assignees
Labels
RFE Request for Enhancement security Security Issue
Milestone

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/50010


Issue Description

Support ECDSA private keys. This is both:

  • Pure ECDSA
  • Mixed RSA + ECDSA support

How this looks today is unknown. However, it doesn't work given:

/opt/dirsrv/sbin/ns-slapd -d 0 -D /opt/dirsrv/etc/dirsrv/slapd-localhost 
Assertion failure: ((*privkey)->keyType) == rsaKey, at /home/william/development/389ds/ds/ldap/servers/slapd/ssl.c:2893
[1]    12717 abort      /opt/dirsrv/sbin/ns-slapd -d 0 -D /opt/dirsrv/etc/dirsrv/slapd-localhost


This is important as it blocks us from using strong future proof cryptographic mechanisms in TLS.

This may be of interest to @kenoh.

Important would be establishment of a ECDSA type in the nss_ssl.py module so we can test this properly and programmatically.

@389-ds-bot 389-ds-bot added RFE Request for Enhancement security Security Issue labels Sep 13, 2020
@389-ds-bot 389-ds-bot added this to the 1.4.4 milestone Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-01-03 17:53:57

Metadata Update from @mreynolds389:

  • Custom field component adjusted to None
  • Custom field origin adjusted to None
  • Custom field reviewstatus adjusted to None
  • Custom field type adjusted to None
  • Custom field version adjusted to None
  • Issue set to the milestone: 1.4.1

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-01-15 06:20:04

@kenoh We've just had a request for this in 50160, so it would be great if you could look into this soon! Thanks,

@389-ds-bot
Copy link
Author

Comment from mhonek (@kenoh) at 2019-01-15 09:46:36

Metadata Update from @kenoh:

  • Issue assigned to kenoh

@389-ds-bot
Copy link
Author

Comment from mhonek (@kenoh) at 2019-03-06 16:29:08

Metadata Update from @kenoh:

  • Issue tagged with: RFE, Security

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-02-26 16:48:33

Metadata Update from @mreynolds389:

  • Issue priority set to: normal
  • Issue set to the milestone: 1.4.4 (was: 1.4.1)

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-07-21 18:16:29

Metadata Update from @mreynolds389:

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-07-21 18:16:29

Issue linked to Bugzilla: Bug 1859298

@Firstyear
Copy link
Contributor

It sounds like when a user attempts a pure ecdsa key that this can lead to some misleading/vague errors, so we should consider implementing this sooner-than-later.

@progier389
Copy link
Contributor

master branch commit is: d522c92

fe18673..d522c92 master
4b73514..d420d06 389-ds-base-2.1 -> 389-ds-base-2.1
19b989d..1a41447 389-ds-base-2.0 -> 389-ds-base-2.0

@mreynolds389
Copy link
Contributor

9dd47cc..893710d 389-ds-base-1.4.3 -> 389-ds-base-1.4.3

@mreynolds389 mreynolds389 modified the milestones: 2.0.0, 1.4.3 Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFE Request for Enhancement security Security Issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants