PR - Issue 50037 - lib389 fails to install in venv under non-root user

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50085

• Created at 2018-12-12 17:07:26 by vashirov (@vashirov)
• Merged at 2019-05-23 11:46:45

---

Bug description:
Some files were installed using absolute path, preventing installation
under non-root user.

Fix description:
Change paths to be relative to the current prefix.
Update .gitignore to exlcude venv.
Update tox.ini to the current supported Python versions.

Resolves: #3096

Reviewed by: ???

[389-ds-bot]

Comment from mhonek (@kenoh) at 2018-12-12 20:50:52

If that would be beneficial for venv installation, could we simply install using scripts and move the files into /usr/sbin after running setup.py (probably both in Makefile.am and the SPEC file).

Anyway, building from SPEC file does not work for me as manpages are now installed into /usr/man/man8 instead of /usr/share/man/man8 (%{_mandir} macro in SPEC file expands to /usr/share/man).

I mean, we should probably respect the way of setup.py and post-adjust as required.

[389-ds-bot]

Comment from vashirov (@vashirov) at 2018-12-20 18:19:49

rebased onto 964eacfa112acb5647d762c76647d078904a2888

[389-ds-bot]

Comment from vashirov (@vashirov) at 2018-12-20 18:29:06

I've adjusted setup.py to fix rpm build.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2019-01-07 04:05:13

This looks good to me, but I have not run rpm build.

[389-ds-bot]

Comment from spichugi (@droideck) at 2019-03-07 21:40:00

Is it still relevant? Could you please rebase so we can test it and probably merge?

[389-ds-bot]

Comment from vashirov (@vashirov) at 2019-05-22 17:24:28

rebased onto c4a2eb4

[389-ds-bot]

Comment from vashirov (@vashirov) at 2019-05-22 17:25:07

@droideck, yes it's still relevant. I've updated the patch.

[389-ds-bot]

Comment from spichugi (@droideck) at 2019-05-23 11:39:32

LGTM! Ack

[389-ds-bot]

Comment from vashirov (@vashirov) at 2019-05-23 11:46:45

Pull-Request has been merged by vashirov

[389-ds-bot]

Patch
50085.patch