PR - Issue 49588 - Add py3 support for tickets : part-5

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50089

• Created at 2018-12-14 12:28:57 by aadhikari
• Merged at 2018-12-17 14:47:39

---

Description: Added py3 support by explicitly changing strings to bytes.
Fixed old legacy objects.

Resolves: #2647

Reviewed by: ??

[389-ds-bot]

Comment from aadhikari at 2018-12-14 12:35:48

rebased onto 7441b53541a2405a3bac31f6e2ea666a5ccf98e9

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-12-14 15:48:40

LGTM

[389-ds-bot]

Comment from aadhikari at 2018-12-14 16:50:52

Hi, @mreynolds389 I am observing some regression.
observation:
dirsrvtests/tests/tickets/ticket48325_test.py working in 1.4.0.16-1.fc29 NOT in 1.4.0.19-2.module+el8+1+36e60e1d
dirsrvtests/tests/tickets/ticket49303_test.py working in 1.4.0.18-1.fc28 NOT in 1.4.0.16-1.fc29 OR 1.4.0.19-2.module+el8+1+36e60e1d

I will need to go through the details, what is changed.

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-12-14 16:58:34

What tests are failing in the latest build?

[389-ds-bot]

Comment from aadhikari at 2018-12-14 17:29:06

@mreynolds389
dirsrvtests/tests/tickets/ticket48325_test.py failing in 1.4.0.19-2.module+el8+1+36e60e1d

dirsrvtests/tests/tickets/ticket49303_test.py failing in both 1.4.0.16-1.fc29 AND 1.4.0.19-2.module+el8+1+36e60e1d

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-12-14 22:43:19

@mreynolds389
dirsrvtests/tests/tickets/ticket48325_test.py failing in 1.4.0.19-2.module+el8+1+36e60e1d

This is because we changed the default repl manager DN, please change "cn=replrepl,cn=config" to "cn=replication manager,cn=config"

dirsrvtests/tests/tickets/ticket49303_test.py failing in both 1.4.0.16-1.fc29 AND 1.4.0.19-2.module+el8+1+36e60e1d

This passes for me on F28 using 1.4.0.20

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-12-14 23:00:49

this should be "cn=replication manager,cn=config", also need to update the "cn" value too.

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-12-14 23:02:59

Use "cn=replication manager,cn=config" here too

[389-ds-bot]

Comment from aadhikari at 2018-12-17 08:44:21

rebased onto a806bcb0ea1826f27b64b962e9bf6867ea060109

[389-ds-bot]

Comment from aadhikari at 2018-12-17 08:45:53

rebased onto 07b367e

[389-ds-bot]

Comment from aadhikari at 2018-12-17 13:15:03

@mreynolds389 Changes have been made!

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-12-17 14:47:10

@mreynolds389 Changes have been made!

Thanks! I'll merge this to master branch

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2018-12-17 14:47:39

Pull-Request has been merged by mreynolds389

[389-ds-bot]

Patch
50089.patch