Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fetch_attr to slapi_fetch_attr #3149

Closed
389-ds-bot opened this issue Sep 13, 2020 · 6 comments
Closed

Rename fetch_attr to slapi_fetch_attr #3149

389-ds-bot opened this issue Sep 13, 2020 · 6 comments
Labels
closed: fixed Migration flag - Issue

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/50090


Commit https://pagure.io/389-ds-base/c/ac500d378 moved unified the fetch_attr helper function and added it to the public API. This caused an issue in IPA, because IPA's sidgen plugin also defines a fetch_attr helper.

The name fetch_attr is pretty much generic and probably used by other plugins, too. Could you please namespace the function and rename it to slapi_fetch_attr?

@389-ds-bot 389-ds-bot added the closed: fixed Migration flag - Issue label Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2018-12-14 15:51:42

Metadata Update from @mreynolds389:

  • Issue assigned to mreynolds389

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2018-12-14 15:52:01

Metadata Update from @mreynolds389:

  • Custom field component adjusted to None
  • Custom field origin adjusted to None
  • Custom field reviewstatus adjusted to None
  • Custom field type adjusted to None
  • Custom field version adjusted to None

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2018-12-14 15:52:11

Yup I'll get this changed...

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2018-12-14 19:06:03

Metadata Update from @mreynolds389:

  • Issue set to the milestone: 1.3.8

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2018-12-14 19:18:22

967d0aa..9130787 master -> master

b757a07..6084978 389-ds-base-1.3.9 -> 389-ds-base-1.3.9

87aed55..60b97ef 389-ds-base-1.3.8 -> 389-ds-base-1.3.8

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2018-12-14 19:18:30

Metadata Update from @mreynolds389:

  • Issue close_status updated to: fixed
  • Issue set to the milestone: None (was: 1.3.8)
  • Issue status updated to: Closed (was: Open)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: fixed Migration flag - Issue
Projects
None yet
Development

No branches or pull requests

1 participant