Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Issue 50152 - Replace os.getenv('HOME') with os.path.expanduser #3216

Closed
389-ds-bot opened this issue Sep 13, 2020 · 5 comments
Closed
Labels
merged Migration flag - PR pr Migration flag - PR

Comments

@389-ds-bot
Copy link

389-ds-bot commented Sep 13, 2020

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50157

  • Created at 2019-01-14 21:03:36 by spichugi (@droideck)
  • Merged at 2019-01-16 11:27:39

Description: When HOME env var is not set, the call will fail with an exception.
Instead of HOME we can use expanduser method. The expanduser will do the right thing
and get home directory on all platforms from either env vars or password database.

Resolves: #3211

Reviewed by: ?

@389-ds-bot 389-ds-bot added merged Migration flag - PR pr Migration flag - PR labels Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-01-14 21:04:45

LGTM

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-01-15 01:17:41

Ack

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2019-01-16 11:27:16

rebased onto ada2dfd

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2019-01-16 11:27:39

Pull-Request has been merged by droideck

@389-ds-bot
Copy link
Author

Patch
50157.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Migration flag - PR pr Migration flag - PR
Projects
None yet
Development

No branches or pull requests

1 participant