PR - Ticket 50195 - improve selinux error messages in interactive

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50196

• Created at 2019-02-04 02:19:39 by firstyear (@Firstyear)
• Merged at 2019-02-06 01:17:26

---

Bug Description: During an interactive install, the selinux
module if not found would produce many error messages that
were not necessary.

Fix Description: Warn the user at the start of the install
that selinux isn't found, and allow them to continue

Resolves: #3254

Author: William Brown william@blackhats.net.au

Review by: ???

[389-ds-bot]

Comment from spichugi (@droideck) at 2019-02-04 11:43:11

dirsrvtests/tests/suites/basic/basic_test.py::test_dscreate fails on our testing environment (F29):

Port 3636 was already labelled with: (servistaitsm_port_t)  Please choose a different port number

[389-ds-bot]

Comment from spichugi (@droideck) at 2019-02-04 11:45:55

Should be :returns: bool (Sphinx docs https://thomas-cokelaer.info/tutorials/sphinx/rest_syntax.html )

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2019-02-05 02:19:39

rebased onto dc715bf0e19d954f1e6dec13e359c516bd67df6e

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2019-02-05 02:19:43

@droideck If you look, my patch doesn't cause that breakage ... it was already broken. I will fix it in 50198.

Anyway, I have fixed the returns string for you :)

[389-ds-bot]

Comment from spichugi (@droideck) at 2019-02-05 16:53:41

Sorry, missed it in the first review. It should accept uppercase too.

[389-ds-bot]

Comment from spichugi (@droideck) at 2019-02-05 16:54:09

Otherwise, looks good to me!

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2019-02-06 01:16:58

rebased onto d8a94c2

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2019-02-06 01:17:26

Pull-Request has been merged by Firstyear

[389-ds-bot]

Patch
50196.patch