Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Ticket 50259 - implement dn construction test #3326

Closed
389-ds-bot opened this issue Sep 13, 2020 · 12 comments
Closed

PR - Ticket 50259 - implement dn construction test #3326

389-ds-bot opened this issue Sep 13, 2020 · 12 comments
Labels
merged Migration flag - PR pr Migration flag - PR

Comments

@389-ds-bot
Copy link

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50267


Bug Description: Implement a lib389 dn test to show we have correct
behaviour with dn derivation in lib389 creation.

Fix Description: Add test case.

https://pagure.io/389-ds-base/issue/50259

Author: William Brown william@blackhats.net.au

Review by: ???

@389-ds-bot 389-ds-bot added merged Migration flag - PR pr Migration flag - PR labels Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2019-03-07 17:29:12

Add the docstrings, please. All the tests under suites are used for generating test plans. It uses the certain docstring structure that can be found in other test suites.

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-03-08 02:10:21

Opps. Yep, I'll add those.

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-03-08 06:15:19

No problem mate, added these :)

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-03-08 06:15:20

rebased onto 907ffbabb2f1892459dafd057ecee4e9c9e335cf

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2019-03-08 18:53:32

You can remove these comments now and uncomment the rest. It should work with my recently merged PR

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-03-11 01:42:26

Yep, I'll make that PR today then.

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-03-11 03:27:34

Updated, thanks!

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-03-11 03:27:38

rebased onto cbdbd0e65a6bf505b0de5c0137bf257f1e926b5c

@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2019-03-11 18:57:56

LGTM!

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-03-12 02:57:01

rebased onto 813030c

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-03-12 03:02:39

Pull-Request has been merged by Firstyear

@389-ds-bot
Copy link
Author

Patch
50267.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Migration flag - PR pr Migration flag - PR
Projects
None yet
Development

No branches or pull requests

1 participant