New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR - Ticket 50303 - Add task creation date to task data #3363
Comments
Comment from spichugi (@droideck) at 2019-03-27 16:54:54 The code looks good to me. Also the change works and outputs the date in a format:
Could you please add some simple test for the feature? |
Comment from firstyear (@Firstyear) at 2019-03-28 00:39:21 Is this attribute in schema? |
Comment from mreynolds (@mreynolds389) at 2019-03-28 01:51:02
None of the task attributes are in the schema :-/ |
Comment from firstyear (@Firstyear) at 2019-03-28 01:52:49 Is this a time where we should add them then? |
Comment from mreynolds (@mreynolds389) at 2019-04-02 19:23:56 rebased onto c99aef54a7467b77e2a4315b28d0ecee82f00aaa |
Comment from mreynolds (@mreynolds389) at 2019-04-02 19:25:30 @Firstyear - updated schema. I left "extensibleObject" in the task creation because it looks like many other tasks randomly add unknown attributes. We can look into that later, but at least the core task schema is defined. Please review... |
Comment from mreynolds (@mreynolds389) at 2019-04-02 19:35:56 rebased onto 39ea1360782748df8a4c20fd12bda5579db87ecf |
Comment from mreynolds (@mreynolds389) at 2019-04-02 22:37:16 rebased onto cb56598ca3c6e39b4b53f478a6dd8d46f15ebf5a |
Comment from mreynolds (@mreynolds389) at 2019-04-02 22:42:27 rebased onto 8f6d8db76ebcccb2d55610eb0c475c2af6d0ef5c |
Comment from firstyear (@Firstyear) at 2019-04-03 00:20:52 Perfect, thank you! If every time wedo this, we add a bit more, we'll eventually be rid of extensibleObject in dse.ldif .... Ack! |
Comment from mreynolds (@mreynolds389) at 2019-04-03 03:08:36 rebased onto 78003de |
Comment from mreynolds (@mreynolds389) at 2019-04-03 03:09:54 Pull-Request has been merged by mreynolds389 |
Patch |
Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50304
Description:
Add a new attribute to the slapi task entry containing the start date. This provides a nice convenience without having to change LDAP clients.
Resolves: #3362
Reviewed by: ?
The text was updated successfully, but these errors were encountered: