Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Ticket 50303 - Add task creation date to task data #3363

Closed
389-ds-bot opened this issue Sep 13, 2020 · 13 comments
Closed

PR - Ticket 50303 - Add task creation date to task data #3363

389-ds-bot opened this issue Sep 13, 2020 · 13 comments
Labels
merged Migration flag - PR pr Migration flag - PR

Comments

@389-ds-bot
Copy link

389-ds-bot commented Sep 13, 2020

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50304


Description:

Add a new attribute to the slapi task entry containing the start date. This provides a nice convenience without having to change LDAP clients.

Resolves: #3362

Reviewed by: ?

@389-ds-bot 389-ds-bot added merged Migration flag - PR pr Migration flag - PR labels Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from spichugi (@droideck) at 2019-03-27 16:54:54

The code looks good to me. Also the change works and outputs the date in a format:

nstaskcreated: 20190327154713Z

Could you please add some simple test for the feature?

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-03-28 00:39:21

Is this attribute in schema?

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-03-28 01:51:02

Is this attribute in schema?

None of the task attributes are in the schema :-/

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-03-28 01:52:49

Is this a time where we should add them then?

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-04-02 19:23:56

rebased onto c99aef54a7467b77e2a4315b28d0ecee82f00aaa

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-04-02 19:25:30

@Firstyear - updated schema. I left "extensibleObject" in the task creation because it looks like many other tasks randomly add unknown attributes. We can look into that later, but at least the core task schema is defined.

Please review...

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-04-02 19:35:56

rebased onto 39ea1360782748df8a4c20fd12bda5579db87ecf

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-04-02 22:37:16

rebased onto cb56598ca3c6e39b4b53f478a6dd8d46f15ebf5a

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-04-02 22:42:27

rebased onto 8f6d8db76ebcccb2d55610eb0c475c2af6d0ef5c

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-04-03 00:20:52

Perfect, thank you! If every time wedo this, we add a bit more, we'll eventually be rid of extensibleObject in dse.ldif ....

Ack!

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-04-03 03:08:36

rebased onto 78003de

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-04-03 03:09:54

Pull-Request has been merged by mreynolds389

@389-ds-bot
Copy link
Author

Patch
50304.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Migration flag - PR pr Migration flag - PR
Projects
None yet
Development

No branches or pull requests

1 participant