PR - Ticket 50363 - ds-replcheck incorrectly reports error for out of order multi-valued attributes

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50364

• Created at 2019-05-10 23:03:43 by mreynolds (@mreynolds389)
• Merged at 2019-05-13 15:59:04

---

Bug Description:

If for some reason an entry's multi-valued attribute values are in different orders on different replicas the tool reports this as an inconsistency when it is not.

Fix Description:

For both offline & online processing sort each entry's multi-valued attribute values.

Resolves: #3422

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2019-05-13 03:26:04

I think this fix is okay, but curious if there is possibly a way to sort these in the lib389 tools in mapped_object or similar so we avoid this problem? Ack if you just want merge though.

[389-ds-bot]

Comment from mhonek (@kenoh) at 2019-05-13 13:45:04

We could do here something like ...{k.lower(): sorted(v) for... instead of the block below, I guess. Something similar in the next added block as well, probably.

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2019-05-13 14:55:09

We could do here something like ...{k.lower(): sorted(v) for... instead of the block below, I guess. Something similar in the next added block as well, probably.

Yeah I tried: {k.lower(): v.sort() for...} but it didn't work. I don't fully understand these type of "for loops" - need to re-read that stuff :-) I'll give this a shot, thanks!

@Firstyear

I think this fix is okay, but curious if there is possibly a way to sort these in the lib389 tools in mapped_object or similar so we avoid this problem?

Well this is outside of mapped objects in this CLI tool (ds-replcheck). It calling raw search_s and getting an "Entry". And in the other case it's built from an LDIF file (no search - it's all manually built), but I might be able to use the LDIF module for that. I'll open a new ticket to refactor the tool for mapped objects, and investigate using the LDIF module.

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2019-05-13 15:55:45

rebased onto 6c805f344e511fd919c84043481ef21cd24f47fe

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2019-05-13 15:56:55

rebased onto 974c802

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2019-05-13 15:59:04

Pull-Request has been merged by mreynolds389

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2019-05-14 01:18:00

Cool, no problems then :) just wanted to be sure this was checked as you are more familar with this code than I am.

[389-ds-bot]

Patch
50364.patch