PR - Issue 50365 - PIDFile= references path below legacy directory /var/run/

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50424

• Created at 2019-06-04 15:46:51 by mhonek (@kenoh)
• Merged at 2019-06-07 14:44:44

---

Bug description:
SystemD complains the PIDFile= in the .service file points into a legacy
directory /var/run

Fix description:
Drop '@localstatedir@' which interpolates to '/var'. Although the actual
directory referenced everywhere else is the one prefixed with '/var' it
should not pose a problem since every environment SystemD is supposed to
run in has to have absolute path `/run' present which is effectively
always linked to the legacy '/var/run'.

Fixes Resolves: #3424

Author: Matus Honek kenoh@redhat.com

Review by: ???

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2019-06-04 15:52:14

What is the impact of this on PREFIX builds? Or other platforms that install under /opt (or whatever)? Just want to make sure we don't break anybody with this change.

[389-ds-bot]

Comment from vashirov (@vashirov) at 2019-06-04 16:01:22

Shouldn't we update ldap/admin/src/defaults.inf.in as well?

[389-ds-bot]

Comment from vashirov (@vashirov) at 2019-06-05 16:17:42

Shouldn't we update ldap/admin/src/defaults.inf.in as well?

This seems to work fine without update, since /run is symlinked to /var/run.

[389-ds-bot]

Comment from mhonek (@kenoh) at 2019-06-05 16:51:43

@vashirov Thanks for checking. I'd keep the defaults.inf as before then.

@mreynolds389 As we discussed, it is not likely one gets to have a systemd compiled in a way that would allow for loading services' files from locations different from this default. Also, as Thierry and Ludwig confirmed, when they do the prefix builds they actually don't use the systemd services for running the server, as that would not work anyway.

I believe we're green here. If no one objects then I would merge this soon.

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2019-06-07 10:54:33

I think we'll find out once it's merged if anything goes wrong, the scream test is always effective. All good from me :)

[389-ds-bot]

Comment from mhonek (@kenoh) at 2019-06-07 14:43:27

rebased onto c96ef35

[389-ds-bot]

Comment from mhonek (@kenoh) at 2019-06-07 14:44:45

Pull-Request has been merged by kenoh

[389-ds-bot]

Patch
50424.patch