Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jemalloc LD_PRELOAD to systemd drop-in file #3483

Closed
389-ds-bot opened this issue Sep 13, 2020 · 8 comments
Closed

Add jemalloc LD_PRELOAD to systemd drop-in file #3483

389-ds-bot opened this issue Sep 13, 2020 · 8 comments
Labels
closed: fixed Migration flag - Issue
Milestone

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/50425


Issue Description

With the very recent changes to systemd we "lost" our LD_PRELAOD of jemalloc. We need to add it back to the new custom drop-in file

@389-ds-bot 389-ds-bot added the closed: fixed Migration flag - Issue label Sep 13, 2020
@389-ds-bot 389-ds-bot added this to the 1.4.1 milestone Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from mhonek (@kenoh) at 2019-06-06 09:31:17

As Viktor pointed out, we should not preload jemalloc in case of ASAN build. Therefore, I would suggest to have a separate drop-in file doing this, which would then be installed only when necessary (similarly to xsan.conf, but in the other case).

Also, seems like *-initconfig files are not necessary after the recent cleanup either. Changes along the patch attached should fix this.
0001-Drop-initconfig-files-in-case-of-SystemD.patch

@389-ds-bot
Copy link
Author

Comment from mhonek (@kenoh) at 2019-06-06 09:31:18

Metadata Update from @kenoh:

  • Custom field origin adjusted to None
  • Custom field reviewstatus adjusted to None

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-06-06 14:29:42

I also have a working patch for this(needs some cleanup though), but preloading jemalloc must be the default behavior.

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-06-06 16:00:28

@kenoh do we still need those init files for non-systemd systems? It's going to complicate the spec file otherwise.

@389-ds-bot
Copy link
Author

389-ds-bot commented Sep 13, 2020

Comment from mreynolds (@mreynolds389) at 2019-07-16 00:00:53

Filed #3557 We need to get this addressed one way or another, and sooner than later. I filed a PR but its just one of many ways we could solve this.

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-07-16 21:25:04

Commit 7466be33 relates to this ticket

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-07-16 21:28:57

Metadata Update from @mreynolds389:

  • Issue close_status updated to: fixed
  • Issue status updated to: Closed (was: Open)

@389-ds-bot
Copy link
Author

Comment from mhonek (@kenoh) at 2019-07-17 15:08:44

Commit 76c0e75a relates to this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: fixed Migration flag - Issue
Projects
None yet
Development

No branches or pull requests

1 participant