Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Issue 49997 - Add a new CI test case #3526

Closed
389-ds-bot opened this issue Sep 13, 2020 · 14 comments
Closed

PR - Issue 49997 - Add a new CI test case #3526

389-ds-bot opened this issue Sep 13, 2020 · 14 comments
Labels
merged Migration flag - PR pr Migration flag - PR

Comments

@389-ds-bot
Copy link

389-ds-bot commented Sep 13, 2020

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50469

  • Created at 2019-06-25 15:15:23 by aadhikari
  • Merged at 2019-07-03 17:25:09

Bug Description: If the suffix provided in the command line does not exist or it's
not replicated, we have an error message that it's regarding the RUV

Fix Description: Added a test case that will validate if a wrong suffix is passed then
a proper error message is displayed or not.

Resolves: #3056

Review by: ???

@389-ds-bot 389-ds-bot added merged Migration flag - PR pr Migration flag - PR labels Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from aadhikari at 2019-06-25 15:17:35

root@fedora29-aadhikar1 ds_tools]# ds-replcheck
No action provided, here is some --help.
usage: ds-replcheck [-h] [-v] {state,online,offline} ...

[root@fedora29-aadhikar1 ds_tools]# rpm -qa | grep 389
389-ds-base-libs-1.4.0.23-1.fc29.x86_64
python3-lib389-1.4.0.23-1.fc29.noarch
389-ds-base-legacy-tools-1.4.0.23-1.fc29.x86_64
389-ds-base-1.4.0.23-1.fc29.x86_64
389-ds-base-snmp-1.4.0.23-1.fc29.x86_64
cockpit-389-ds-1.4.0.23-1.fc29.noarch

Not sure on which version we have this change, also I see in the test above it's 1.4.1.2, must be missing something.

@389-ds-bot
Copy link
Author

Comment from aadhikari at 2019-06-25 15:20:20

I tried using check_output but was not able to get the exact solution for this, not sure what would be the best way, please suggest?

@389-ds-bot
Copy link
Author

Comment from aadhikari at 2019-06-25 15:23:27

rebased onto 33623d1bd13addc89717c5df2c96e770bbee041f

@389-ds-bot
Copy link
Author

Comment from aadhikari at 2019-06-26 10:55:42

rebased onto 043043f5b9a8db4a92e515108df714610a2e8f96

@389-ds-bot
Copy link
Author

Comment from aadhikari at 2019-06-26 11:01:24

rebased onto 261a128e0b0f183a503478a910c6df650e203ab5

@389-ds-bot
Copy link
Author

Comment from aadhikari at 2019-06-27 08:29:20

rebased onto 818d90d3bcd1042ee7dee7daae93a018a98fee9b

@389-ds-bot
Copy link
Author

Comment from vashirov (@vashirov) at 2019-07-02 21:13:06

Only tool_cmd string construction needs to be in if statement, the rest is the same.

@389-ds-bot
Copy link
Author

Comment from vashirov (@vashirov) at 2019-07-02 21:13:39

Please update your commit message to have 'Relates' before the issue URL.

@389-ds-bot
Copy link
Author

Comment from aadhikari at 2019-07-03 16:36:18

rebased onto 90d38c83d7b427ecb8322407074d9c350ef16799

@389-ds-bot
Copy link
Author

Comment from aadhikari at 2019-07-03 16:37:05

@vashirov Changes have been made.

@389-ds-bot
Copy link
Author

Comment from aadhikari at 2019-07-03 16:41:27

rebased onto 858275cf4644734071fa421fa5de06818182f3a7

@389-ds-bot
Copy link
Author

Comment from aadhikari at 2019-07-03 17:02:56

rebased onto 70ba6e3

@389-ds-bot
Copy link
Author

Comment from vashirov (@vashirov) at 2019-07-03 17:25:10

Pull-Request has been merged by vashirov

@389-ds-bot
Copy link
Author

Patch
50469.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Migration flag - PR pr Migration flag - PR
Projects
None yet
Development

No branches or pull requests

1 participant