PR - Issue: 48055 - CI test-(Plugin configuration should throw proper error messages if not configured properly)

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50527

• Created at 2019-08-02 09:44:33 by aborah (@aborah-sudo)
• Merged at 2019-08-28 13:01:49

---

CI test-(Plugin configuration should throw proper error messages if not configured properly)

Relates: Resolves: #1386

Author: aborah-sudo

Reviewed by: ???

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2019-08-02 09:47:03

rebased onto 5e789a8ecdda824fefcabdf55d2d2945ad525d75

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2019-08-02 09:48:43

rebased onto 48a040dae891931d7e88daa4f1022c54108a5eeb

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2019-08-02 10:59:32

rebased onto 8b1ba638eb74827c825c0c4dac35424504682ffb

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2019-08-02 14:23:21

rebased onto b5c41a969542cf0990a5bb081df2a71bf6326556

[389-ds-bot]

Comment from spichugi (@droideck) at 2019-08-22 17:06:40

Extra line

[389-ds-bot]

Comment from spichugi (@droideck) at 2019-08-22 17:07:04

It is already included in AutoMembershipPlugin

[389-ds-bot]

Comment from spichugi (@droideck) at 2019-08-22 17:07:22

There is no description

[389-ds-bot]

Comment from spichugi (@droideck) at 2019-08-22 17:08:06

it is also about mixing the suffixes for autoMemberDefaultGroup

[389-ds-bot]

Comment from spichugi (@droideck) at 2019-08-22 17:08:59

What do you need replication for? Why not use 'standalone'?

[389-ds-bot]

Comment from spichugi (@droideck) at 2019-08-22 17:11:10

Please, use lib389/dirsrv_log.
We will deprecate searchErrorsLog soon

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2019-08-22 17:59:49

Please, use lib389/dirsrv_log.
We will deprecate searchErrorsLog soon

(Pdb) dirlog1 = DirsrvLog(topo.standalone)
(Pdb) DirsrvErrorLog(dirlog1)
<lib389.dirsrv_log.DirsrvErrorLog object at 0x7f830081c3c8>
(Pdb) DirsrvErrorLog(dirlog1).parse_line('ERR - auto-membership-plugin')
*** AttributeError: 'NoneType' object has no attribute 'groupdict'

Looks like lib389/dirsrv_log. does not work properly

[389-ds-bot]

Comment from spichugi (@droideck) at 2019-08-22 18:12:06

(Pdb) dirlog1 = DirsrvLog(topo.standalone)
(Pdb) DirsrvErrorLog(dirlog1)
<lib389.dirsrv_log.dirsrverrorlog object="" at="" 0x7f830081c3c8="">

I am not sure what you are doing here...

Try to search for the examples in our code (basically lib389/dirsrv_log is used only for creating an alias in DirSrv() object)

And you can use these aliases to perform tasks (once again, you can find a lot of examples through the code).

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2019-08-22 18:54:25

1 new commit added

• finxing simo5n's comments

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2019-08-22 18:55:21

@droideck changes are done as your suggestion

[389-ds-bot]

Comment from spichugi (@droideck) at 2019-08-23 17:22:23

The test module name still has the bz number in it dirsrvtests/tests/suites/automember_plugin/bz834056_test.py ...

test_mmr_setup_mixed_the_plugin_configuration can be misinterpreted...
Like mmr_setup mixed the_plugin_configuration...

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2019-08-23 17:35:01

rebased onto 5a35ff13baae89d6221d26279bb2e304a8cc46d5

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2019-08-23 17:35:54

The test module name still has the bz number in it dirsrvtests/tests/suites/automember_plugin/bz834056_test.py ...
test_mmr_setup_mixed_the_plugin_configuration can be misinterpreted...
Like mmr_setup mixed the_plugin_configuration...

renamed test case and module name.

[389-ds-bot]

Comment from spichugi (@droideck) at 2019-08-26 10:21:48

automembership_plugin is already in the test dir name.
So I think it can be removed from the module name and from the test case name.

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2019-08-26 10:28:28

rebased onto ca7b405aa9af7011ac089e4bd8c410c3c1b7a21e

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2019-08-26 10:31:52

rebased onto 46639d5190ee93f7457e4dc3afdaaf80a170c0c8

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2019-08-26 10:32:45

automembership_plugin is already in the test dir name.
So I think it can be removed from the module name and from the test case name.

renamed both (module and test case )

[389-ds-bot]

Comment from spichugi (@droideck) at 2019-08-26 10:43:23

LGTM. Ack

[389-ds-bot]

Comment from aborah (@aborah-sudo) at 2019-08-28 12:03:31

rebased onto 723b88a

[389-ds-bot]

Comment from vashirov (@vashirov) at 2019-08-28 13:01:49

Pull-Request has been merged by vashirov

[389-ds-bot]

Patch
50527.patch