PR - Issue 49324 - idl_new report index name in error conditions

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50563

• Created at 2019-08-23 20:19:07 by mreynolds (@mreynolds389)
• Merged at 2019-08-26 16:51:37

---

Description: Add the index attribute name to error messages

relates: Resolves: #2383

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2019-08-26 03:06:12

Is there ever a case where key.data or the attribute would be NULL?

I think I'd like some PR_ASSERT() on the value that's passed to the %s format, but that's just paranoia. Otherwise I think this is a good change.

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2019-08-26 16:29:59

rebased onto f47b2d8b8abedff135ad34c189b0b5bfa5fd0140

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2019-08-26 16:30:41

Is there ever a case where key.data or the attribute would be NULL?
I think I'd like some PR_ASSERT() on the value that's passed to the %s format, but that's just paranoia. Otherwise I think this is a good change.

@Firstyear - Added a PR_ASSERT to the top of the function, please review...

[389-ds-bot]

Comment from tbordaz (@tbordaz) at 2019-08-26 16:45:37

LGTM as well.

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2019-08-26 16:50:38

rebased onto 441d5ab

[389-ds-bot]

Comment from mreynolds (@mreynolds389) at 2019-08-26 16:51:37

Pull-Request has been merged by mreynolds389

[389-ds-bot]

Patch
50563.patch