Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Issue 50580 - Perl can't be disabled in configure #3645

Closed
389-ds-bot opened this issue Sep 13, 2020 · 4 comments
Closed

PR - Issue 50580 - Perl can't be disabled in configure #3645

389-ds-bot opened this issue Sep 13, 2020 · 4 comments
Labels
merged Migration flag - PR pr Migration flag - PR

Comments

@389-ds-bot
Copy link

389-ds-bot commented Sep 13, 2020

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50589

  • Created at 2019-09-07 16:47:58 by mhonek (@kenoh)
  • Merged at 2019-09-11 13:02:56

Bug description:
Due to incorrect use of AC_ARG_ENABLE macro arguments' semantics some
calls like ./configure --disable-* and --enable-=no worked
unexpectedly like --enable-
=yes.

Fix description:
As this issue affects several ./configure options all were fixed. The
fix uses the fourth argument of the AC_ARG_ENABLE to set the default in
case no option was provided. In case an explicit --disable-* or
--enable-* argument was provided to ./configure the respective $enable_*
variable is implicitly populated by autoconf, hence subsequent
if-else statements take care of additional operations based on the
variable's value.

For the record, some implementations of the options pre-set the default
value before the AC_ARG_ENABLE in case the respective $enable_* variable
has not been set. This is a correct approach, hence left as is.

Resolves: Resolves: #3636

Author: Matus Honek kenoh@redhat.com

Review-By: ????

@389-ds-bot 389-ds-bot added merged Migration flag - PR pr Migration flag - PR labels Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-09-10 21:51:01

LGTM

@389-ds-bot
Copy link
Author

Comment from mhonek (@kenoh) at 2019-09-11 13:01:51

rebased onto 00e3331

@389-ds-bot
Copy link
Author

Comment from mhonek (@kenoh) at 2019-09-11 13:02:56

Pull-Request has been merged by kenoh

@389-ds-bot
Copy link
Author

Patch
50589.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Migration flag - PR pr Migration flag - PR
Projects
None yet
Development

No branches or pull requests

1 participant