Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Do not use comparision with "is" for empty value #3647

Closed
389-ds-bot opened this issue Sep 13, 2020 · 4 comments
Closed

PR - Do not use comparision with "is" for empty value #3647

389-ds-bot opened this issue Sep 13, 2020 · 4 comments
Labels
merged Migration flag - PR pr Migration flag - PR

Comments

@389-ds-bot
Copy link

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50591

  • Created at 2019-09-10 18:26:28 by tdudlak
  • Merged at 2019-09-10 18:29:12

There is a warning with python 3.8 at fedora rawhide about
comparision with "is" while running ipa-server install:
dirsrv_log.py:148: SyntaxWarning: "is not" with a literal. Did you mean "!="
Removing "is not ''" as this should not be needed
to make sure that timedata['nanosecond'] is empty.

Signed-off-by: Tibor Dudlák tdudlak@redhat.com

@389-ds-bot 389-ds-bot added merged Migration flag - PR pr Migration flag - PR labels Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from tdudlak at 2019-09-10 18:26:58

  [1/44]: creating directory server instance

Starting installation...
/usr/lib/python3.8/site-packages/lib389/dirsrv_log.py:148: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if timedata['nanosecond'] is not '':
Created symlink /etc/systemd/system/multi-user.target.wants/dirsrv@EXAMPLE-TEST.service → /usr/lib/systemd/system/dirsrv@.service.

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-09-10 18:28:33

LGTM. I'll merge it..

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-09-10 18:29:13

Pull-Request has been merged by mreynolds389

@389-ds-bot
Copy link
Author

Patch
50591.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Migration flag - PR pr Migration flag - PR
Projects
None yet
Development

No branches or pull requests

1 participant