Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds_selinux_enabled may fail on suse in some cases #3677

Closed
389-ds-bot opened this issue Sep 13, 2020 · 8 comments
Closed

ds_selinux_enabled may fail on suse in some cases #3677

389-ds-bot opened this issue Sep 13, 2020 · 8 comments
Labels
closed: fixed Migration flag - Issue

Comments

@389-ds-bot
Copy link

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/50622


Issue Description

We don't check if we have the selinux python module in this command, so it may fail when we do not have it.

@389-ds-bot 389-ds-bot added the closed: fixed Migration flag - Issue label Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-09-26 17:43:46

Metadata Update from @mreynolds389:

  • Custom field origin adjusted to None
  • Custom field reviewstatus adjusted to None
  • Issue set to the milestone: 1.4.2

@389-ds-bot
Copy link
Author

389-ds-bot commented Sep 13, 2020

Comment from tbordaz (@tbordaz) at 2019-09-26 17:45:18

@Firstyear is okay to close it now ? (#3678)

@389-ds-bot
Copy link
Author

Comment from tbordaz (@tbordaz) at 2019-09-26 17:45:18

Metadata Update from @tbordaz:

  • Issue set to the milestone: None (was: 1.4.2)

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-09-27 01:46:15

Not yet, I need to know if it's okay to backport to 1.4.0 and 1.4.1 from @mreynolds389

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-09-30 15:19:05

Not yet, I need to know if it's okay to backport to 1.4.0 and 1.4.1 from @mreynolds389

Yeah of course it s fine. Typically if its not a RFE, or change in behavior, you can backport it to whatever branch you want.

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-10-01 02:50:20

@mreynolds389 Thanks mate. Just want to be sure you know what I'm up to! Rather have your input than surprise you with weird changes is all. I'll backport this today.

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-10-01 02:57:14

commit 6304942ba43282a463e2b29eb66a0afa3ca1f951 (HEAD -> 389-ds-base-1.4.0, origin/389-ds-base-1.4.0)
Author: William Brown <william@blackhats.net.au>
Date:   Wed Sep 25 12:19:37 2019 +1000

    Ticket 50622 - ds_selinux_enabled may crash on suse

commit aa1760272fca05f5be6f82c50baa4db5af6ace50 (HEAD -> 389-ds-base-1.4.1, origin/389-ds-base-1.4.1)
Author: William Brown <william@blackhats.net.au>
Date:   Wed Sep 25 12:19:37 2019 +1000

    Ticket 50622 - ds_selinux_enabled may crash on suse

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-10-01 02:57:15

Metadata Update from @Firstyear:

  • Issue close_status updated to: fixed
  • Issue status updated to: Closed (was: Open)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: fixed Migration flag - Issue
Projects
None yet
Development

No branches or pull requests

1 participant