Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Ticket 50617 - disable cargo lock #3681

Closed
389-ds-bot opened this issue Sep 13, 2020 · 6 comments
Closed

PR - Ticket 50617 - disable cargo lock #3681

389-ds-bot opened this issue Sep 13, 2020 · 6 comments
Labels
merged Migration flag - PR pr Migration flag - PR

Comments

@389-ds-bot
Copy link

389-ds-bot commented Sep 13, 2020

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50626


Bug Description: We need cargo lock for future offline builds, but
the version of cargo in suse/rhel seems to old to support vendoring.

Fix Description: For now, disable this, and rely on "online" builds
(but we have no/few external deps anyway)

Resolves: #3672

Author: William Brown william@blackhats.net.au

Review by: ???

@389-ds-bot 389-ds-bot added merged Migration flag - PR pr Migration flag - PR labels Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-09-25 14:17:07

ack

@389-ds-bot
Copy link
Author

Comment from mhonek (@kenoh) at 2019-09-25 14:43:27

I'm fine with this as well. We should just be aware that e.g. for Fedora's Koji (CentOS likewise) online builds are not an option AFAIK.

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-09-26 01:49:44

Yep, I'm aware - we'll want offline builds at SUSE too. We need cargo vendor to be in place though so that we can pre-download any libs so we can use --locked in our makefile.

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-09-26 02:56:22

rebased onto 4b987b3

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-09-26 02:58:29

Pull-Request has been merged by Firstyear

@389-ds-bot
Copy link
Author

Patch
50626.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Migration flag - PR pr Migration flag - PR
Projects
None yet
Development

No branches or pull requests

1 participant