PR - Ticket 50659 AddressSanitizer: SEGV ... in bdb_pre_close

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50671

• Created at 2019-10-23 17:29:09 by lkrispen (@elkris)
• Merged at 2019-11-14 16:15:27

---

Bug: The crash reported is caused by calling dblayer_close twice in some
offline exec modes. Investigating the crash revealed another crash
in dbverify and memory leaks, one introduced by the backend
patch, two existing previously

Fix: - call dblayer_close only once
- initialize db env properly in dbverify execmode
- don't set sdn by reference when adding to entrydncache
- free collected instances from commandline in dbupgrade mode
- free bdb env in index mode

Reviewed by: ?

[389-ds-bot]

Comment from lkrispen (@elkris) at 2019-11-05 10:09:19

rebased onto 4adca4e7d4ac24611b1a209f9fb49b302c5f3176

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2019-11-12 23:56:14

Looks reasonable to me, my only question is about the removal of dblayer_close()? Is this closed elsewhere?

[389-ds-bot]

Comment from lkrispen (@elkris) at 2019-11-13 09:13:11

Looks reasonable to me, my only question is about the removal of dblayer_close()? Is this closed elsewhere?

yes. and that has caused the crash, trying to free it twice. In the reported scenario it is also called in bdb_upgradedb() and in general it is called above import_main_offline()

[389-ds-bot]

Comment from firstyear (@Firstyear) at 2019-11-14 02:46:32

Ack from me then, this all makes sense.

[389-ds-bot]

Comment from lkrispen (@elkris) at 2019-11-14 16:14:43

rebased onto b77f04a

[389-ds-bot]

Comment from lkrispen (@elkris) at 2019-11-14 16:15:27

Pull-Request has been merged by elkris

[389-ds-bot]

Patch
50671.patch