Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Issue #50683 - Makefile.am contains unused RPM-related targets #3739

Closed
389-ds-bot opened this issue Sep 13, 2020 · 5 comments
Closed
Labels
merged Migration flag - PR pr Migration flag - PR

Comments

@389-ds-bot
Copy link

389-ds-bot commented Sep 13, 2020

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50684

  • Created at 2019-11-01 11:59:26 by mhonek (@kenoh)
  • Merged at 2019-11-11 15:09:25

Bug Description:
Makefile.am contains some targets very similar to the ones in rpm.mk but
most likely unused by anyone and also untouched recently unlike the
rpm.mk ones.

Fix Description:
Remove the targets for cleanness and reducing confusion.

Fixes Resolves: #3738

Author: Matus Honek kenoh@redhat.com

Review by: ???

@389-ds-bot 389-ds-bot added merged Migration flag - PR pr Migration flag - PR labels Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2019-11-04 00:06:25

ack from me,

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2019-11-06 20:53:24

Works for me, all the build methods I use still work.

@389-ds-bot
Copy link
Author

Comment from mhonek (@kenoh) at 2019-11-11 15:07:33

rebased onto 66a21bf

@389-ds-bot
Copy link
Author

Comment from mhonek (@kenoh) at 2019-11-11 15:09:26

Pull-Request has been merged by kenoh

@389-ds-bot
Copy link
Author

Patch
50684.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Migration flag - PR pr Migration flag - PR
Projects
None yet
Development

No branches or pull requests

1 participant