New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR - Issue 50634 - Fix CLI error parsing for non-string values #3774

Closed

389-ds-bot opened this issue Sep 13, 2020 · 5 comments

Labels

merged pr

389-ds-bot commented Sep 13, 2020 •

edited

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50719

Created at 2019-11-14 18:02:26 by spichugi (@droideck)
Merged at 2019-11-14 18:24:57

Bug Description: Sometimes the error message has int values and
it makes ' - '.join() function to fail.

Fix Description: Use a list comprehension to change the dict values to str.

Resolves: #3689

Reviewed by: ?

389-ds-bot added merged pr labels

Author

389-ds-bot commented Sep 13, 2020

Comment from mreynolds (@mreynolds389) at 2019-11-14 18:04:05

ack

389-ds-bot closed this as completed

Author

389-ds-bot commented Sep 13, 2020

Comment from mreynolds (@mreynolds389) at 2019-11-14 18:24:40

I'm merging this as I am about to do a upstream build...

Author

389-ds-bot commented Sep 13, 2020

Comment from mreynolds (@mreynolds389) at 2019-11-14 18:24:57

Pull-Request has been merged by mreynolds389

Author

389-ds-bot commented Sep 13, 2020

Comment from spichugi (@droideck) at 2019-11-14 20:03:08

Thanks! I've cherry-picked the code to 1.4.0 and 1.4.1

Author

389-ds-bot commented Sep 13, 2020

Patch
50719.patch

389-ds-bot mentioned this issue

Clean up CLI errors output #3689

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment