New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.4.2.5 doesn't compile due to error ModuleNotFoundError: No module named 'pkg_resources.extern' #3826
Comments
Comment from svenstaro at 2019-12-09 02:04:25 I'd like to note that setuptools, which seems to be the Python package that is reported to be missing here, is installed in the system. |
Comment from vashirov (@vashirov) at 2019-12-09 14:20:19 Part of the problem seems to be the way But we rely on the way Why we're using So the short term fix would be to patch |
Comment from vashirov (@vashirov) at 2019-12-09 14:20:20 Metadata Update from @vashirov:
|
Comment from eschwartz at 2019-12-09 16:13:15 Why are you relying on private undocumented API? Use |
Comment from vashirov (@vashirov) at 2019-12-09 16:25:06
Because it returns different objects for different version strings: And comparison doesn't work correctly.
|
Comment from eschwartz at 2019-12-09 16:47:10 If you need to handle inconsistent version schemas, then instead of vendoring a library you can simply:
|
Comment from eschwartz at 2019-12-09 16:48:31 Although it seems like it should not be that hard to get a core part of the python ecosystem into RHEL, especially as a new package that doesn't break anything. |
Comment from vashirov (@vashirov) at 2019-12-10 11:11:04 So, given that upstream of
It's very hard to get a new package in RHEL. Moreover, |
Comment from eschwartz at 2019-12-10 15:31:33 That would work, I guess. However, I still think it would make more sense semantically to first try the "correct" way (that uses the official Note that setuptools upstream officially considers it wrong to depend on pkg_resources.extern, and warns that it may be arbitrarily dropped: https://github.com/pypa/setuptools/blob/master/CHANGES.rst#v3600
This was in followup to an actual stage of setuptools' development where the .extern vendored dependencies were, in fact, removed from setuptools and replaced by install_requires dependencies on separately provided global modules. It seems wise to in general try to get to a stage where you're depending on |
Comment from vashirov (@vashirov) at 2019-12-10 16:43:36
I agree with you, that it makes more sense semantically, but in practice we have to work with what we have in RHEL/Fedora.
I don't like to use undocumented APIs either. We'll cross this bridge when we come to it.
I went with using |
Comment from vashirov (@vashirov) at 2019-12-10 16:44:07 Commit bcf5e9f9 fixes this issue |
Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/50771
Issue Description
I'm compiling 1.4.2.5 and I get
Package Version and Platform
1.4.2.5 on Arch Linux
Steps to reproduce
Compile using
Actual results
Expected results
Clean compile. 1.4.2.4 worked just fine except for 50737.
The text was updated successfully, but these errors were encountered: