New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cargo.lock to allow offline builds #3885

Closed

389-ds-bot opened this issue Sep 13, 2020 · 4 comments

Labels

Milestone

389-ds-bot commented Sep 13, 2020

Cloned from Pagure issue: https://pagure.io/389-ds-base/issue/50831

Created at 2020-01-20 05:28:18 by firstyear (@Firstyear)
Closed at 2020-01-28 04:05:26 as fixed
Assigned to firstyear (@Firstyear)

Issue Description

When building offline we require cargo.lock to be updated so that we can correctly do the builds.

See also: https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

389-ds-bot added the closed: fixed label

389-ds-bot added this to the 1.4.3 milestone

389-ds-bot closed this as completed

Author

389-ds-bot commented Sep 13, 2020 •

edited

Comment from firstyear (@Firstyear) at 2020-01-20 05:45:41

Author

389-ds-bot commented Sep 13, 2020

Comment from firstyear (@Firstyear) at 2020-01-20 05:45:42

Metadata Update from @Firstyear:

Custom field origin adjusted to None
Custom field reviewstatus adjusted to None

Author

389-ds-bot commented Sep 13, 2020

Comment from mreynolds (@mreynolds389) at 2020-01-23 17:43:26

Metadata Update from @mreynolds389:

Issue set to the milestone: 1.4.3

Author

389-ds-bot commented Sep 13, 2020

Comment from firstyear (@Firstyear) at 2020-01-28 04:05:27

Metadata Update from @Firstyear:

Issue close_status updated to: fixed
Issue status updated to: Closed (was: Open)

389-ds-bot mentioned this issue

PR - Ticket 50831 add cargo.lock to allow offline builds #3886

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment