PR - Issue 49761 - Fix CI test suite issues

[389-ds-bot]

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50847

• Created at 2020-01-23 15:14:44 by sgouvern
• Merged at 2020-03-09 15:42:18

---

Bug Description:
tickets/ticket48229 test had failures in CI nightly runs

Fix Description:
tickets/ticket48226_test.py file moved and renamed to tests/suite/memory_leaks/MMR_double_free_test.py
Use of Valgrind removed, as support for Valgrind is broken in lib389 - Test run only with ASAN build
Replaced depracated _s functions by use of DSLdapObject

Relates Resolves: #2820

Author: sgouvern

Review by: vashirov, droideck

[389-ds-bot]

Comment from vashirov (@vashirov) at 2020-01-30 10:13:30

This should be a pytest fixture instead of a standalone test.

[389-ds-bot]

Comment from vashirov (@vashirov) at 2020-01-30 10:14:09

Here assert can be used instead of try...except.

[389-ds-bot]

Comment from vashirov (@vashirov) at 2020-01-30 10:16:03

Please also run git rm -f dirsrvtests/tests/tickets/ticket48226_test.py to remove the old ticket.

[389-ds-bot]

Comment from spichugi (@droideck) at 2020-02-13 14:15:38

Wrong copyright.

[389-ds-bot]

Comment from spichugi (@droideck) at 2020-02-13 14:17:35

And we should use Replica(DSLdapObject) or direct search_s. Legacy Replica will be deprecated soon

[389-ds-bot]

Comment from spichugi (@droideck) at 2020-02-13 14:19:03

Alternatively, you can change the comments to log.info calls. It will be nice, I think :)

[389-ds-bot]

Comment from spichugi (@droideck) at 2020-02-13 14:20:36

Small nitpick, please, change the function name to something meaningful. We already have the Issue name in the pytest.mark

[389-ds-bot]

Comment from sgouvern at 2020-02-26 15:29:34

rebased onto 42f7e5f8bfa39e62f350524ca2c3ac7515cfc1cd

[389-ds-bot]

Comment from sgouvern at 2020-02-26 15:35:14

Thanks for your reviews.
I updated the PR taking your remarks into account.

[389-ds-bot]

Comment from vashirov (@vashirov) at 2020-03-09 14:13:00

LGTM!
Please fix up commits and rebase to master.

[389-ds-bot]

Comment from sgouvern at 2020-03-09 14:37:18

rebased onto e48172d9c05d14e8ab8f8ae02a4ba44a9f19b2fa

[389-ds-bot]

Comment from sgouvern at 2020-03-09 14:39:53

Done. Thanks !

[389-ds-bot]

Comment from sgouvern at 2020-03-09 15:38:06

rebased onto bf8b4af

[389-ds-bot]

Comment from vashirov (@vashirov) at 2020-03-09 15:42:18

Pull-Request has been merged by vashirov

[389-ds-bot]

Patch
50847.patch