Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Issue 50954 - buildnum.py - fix date formatting issue #4011

Closed
389-ds-bot opened this issue Sep 13, 2020 · 8 comments
Closed

PR - Issue 50954 - buildnum.py - fix date formatting issue #4011

389-ds-bot opened this issue Sep 13, 2020 · 8 comments
Labels
merged Migration flag - PR pr Migration flag - PR

Comments

@389-ds-bot
Copy link

389-ds-bot commented Sep 13, 2020

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/50958


Description: We need to zero pad the hour and minute is they are less than "10"

relates: Resolves: #4007

@389-ds-bot 389-ds-bot added merged Migration flag - PR pr Migration flag - PR labels Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from mhonek (@kenoh) at 2020-03-16 17:07:18

Hmm, wouldn't it be better to just use time.strftime on whatever the time.gmtime returned? Or is there something missing?

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-03-16 17:15:30

rebased onto e6c368d40c38a3c12d063c1f2b296c0f23f515ad

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-03-16 17:16:02

Hmm, wouldn't it be better to just use time.strftime on whatever the time.gmtime returned? Or is there something missing?

Ah yes, very nice - thanks for the suggestions. Please review...

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-03-16 17:16:46

rebased onto 8451c42e5a713333954101057b80bdd253188290

@389-ds-bot
Copy link
Author

Comment from mhonek (@kenoh) at 2020-03-16 17:51:48

LGTM. Thanks! :)

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-03-16 17:56:20

rebased onto b32c745

@389-ds-bot
Copy link
Author

Comment from mreynolds (@mreynolds389) at 2020-03-16 17:57:30

Pull-Request has been merged by mreynolds389

@389-ds-bot
Copy link
Author

Patch
50958.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Migration flag - PR pr Migration flag - PR
Projects
None yet
Development

No branches or pull requests

1 participant