Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - Ticket 51014 - slapi_pal.c possible static buffer overflow #4068

Closed
389-ds-bot opened this issue Sep 13, 2020 · 6 comments
Closed

PR - Ticket 51014 - slapi_pal.c possible static buffer overflow #4068

389-ds-bot opened this issue Sep 13, 2020 · 6 comments
Labels
merged Migration flag - PR pr Migration flag - PR

Comments

@389-ds-bot
Copy link

389-ds-bot commented Sep 13, 2020

Cloned from Pagure Pull-Request: https://pagure.io/389-ds-base/pull-request/51015


Bug Description: Due to an incorrect use of a buffer size,
static analysis in suse detected a possible overflow in
slapi pal. However, it requires root permissions to exploit
anything, and thus is not a security issues.

Fix Description: Change the buffer we read the cgroup into
to be maxpathlen size.

Resolves: #4067

Author: William Brown william@blackhats.net.au

Review by: ???

@389-ds-bot 389-ds-bot added merged Migration flag - PR pr Migration flag - PR labels Sep 13, 2020
@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2020-04-07 08:33:03

I will backport this to 1.4.2 as well :)

@389-ds-bot
Copy link
Author

Comment from tbordaz (@tbordaz) at 2020-04-07 09:58:59

ACK

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2020-04-08 01:35:00

rebased onto a252a6f

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2020-04-08 01:36:34

Pull-Request has been merged by Firstyear

@389-ds-bot
Copy link
Author

Comment from firstyear (@Firstyear) at 2020-04-08 01:38:29

To ssh://pagure.io/389-ds-base.git
877f628..b213ed4 389-ds-base-1.4.2 -> 389-ds-base-1.4.2

@389-ds-bot
Copy link
Author

Patch
51015.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Migration flag - PR pr Migration flag - PR
Projects
None yet
Development

No branches or pull requests

1 participant